Skip to content

[wasm][debugger] Reusing buffer to avoid allocate every debugger message - #59480

Merged
thaystg merged 9 commits into
dotnet:mainfrom
thaystg:thays_reuse_buffer_debugger
Sep 29, 2021
Merged

[wasm][debugger] Reusing buffer to avoid allocate every debugger message#59480
thaystg merged 9 commits into
dotnet:mainfrom
thaystg:thays_reuse_buffer_debugger

Conversation

@thaystg

@thaystgthaystg commented Sep 22, 2021

Copy link
Copy Markdown
Member

This will speed up debugger and experience and will avoid leaking memory.

@ghost

ghost commented Sep 22, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

This will speed up debugger and experience and will avoid leaking memory.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg

thaystg commented Sep 22, 2021

Copy link
Copy Markdown
MemberAuthor

@pavelsavara I'll wait for your approval to backport :)

@thaystgthaystg added the arch-wasm WebAssembly architecture label Sep 22, 2021
@ghost

ghost commented Sep 22, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This will speed up debugger and experience and will avoid leaking memory.

Author:thaystg
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

pavelsavara
pavelsavara approved these changes Sep 23, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/library_mono.js Outdated
@thaystg

thaystg commented Sep 23, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc2

@github-actions

github-actionsBot commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1265809313

@github-actionsgithub-actionsBot mentioned this pull request Sep 23, 2021
Merged
@thaystg

thaystg commented Sep 28, 2021

Copy link
Copy Markdown
MemberAuthor

@pavelsavara could you please review again, now that it will be merged after your ts changes?

radical
radical reviewed Sep 28, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/src/mono/debug.ts Outdated
pavelsavara
pavelsavara reviewed Sep 28, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/src/mono/debug.ts Outdated
pavelsavara
pavelsavara reviewed Sep 28, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/src/mono/debug.ts Outdated
@thaystg
thaystg merged commit e0e174b into dotnet:mainSep 29, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@radical@pavelsavara@radekdoulik