Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] [wasm][debugger] Reusing buffer to avoid allocate every debugger message - #59523
Merged
Merged
Conversation
ghost
commented
Sep 23, 2021
Tagging subscribers to this area: @thaystg |
ghost
commented
Sep 23, 2021
lewing
commented
Sep 23, 2021
Member
runtime (Installer Build and Test coreclr Linux_musl_x64 Release) failed with |
thaystg
commented
Sep 24, 2021
Member
Approved by email |
Anipik
commented
Sep 24, 2021
Contributor
can we get a code review here ? |
Anipik
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59480 to release/6.0-rc2
/cc @thaystg
Customer Impact
Reuse the buffer will speed up the debugger experience avoiding allocate and deallocate.
Testing
Ran the unit tests
Risk
No risk, it's reusing buffer as it was doing before, but it's correctly allocating a buffer to reuse.