Uh oh!
There was an error while loading. Please reload this page.
Fix behavior ObjectCollection for single item contains - #59547
Conversation
ghost
commented
Sep 23, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContains for a signle item performs a reference-equals, not a semantic equality comparison. Change to use the item's equality definition.
|
geoffkizer
commented
Sep 23, 2021
It looks like we have a similar issue here: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/Headers/ObjectCollection.cs#L123 I don't see any other instances of this in the file, but a second pair of eyeballs would be good... |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Noticed that too - there's a few https://source.dot.net/#System.Net.Http/System/Net/Http/Headers/ContentDispositionHeaderValue.cs,104 and in setting date and name in ContentDisposition |
79ef90c to
d71f442Comparehoyosjs
commented
Sep 24, 2021
/backport to release/6.0-rc2 |
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1268272160 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hoyosjs
commented
Sep 24, 2021
@stephentoub@geoffkizer can you please take a look here and if everything looks OK now approve this and the port? Don't want to keep RC2 in delay. |
Contains for a single item performs a reference-equals, not a semantic equality comparison. Change to use the item's equality definition.