Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] Fix behavior ObjectCollection for single item contains - #59557
Merged
Conversation
ghost
commented
Sep 24, 2021
Tagging subscribers to this area: @dotnet/ncl |
karelz
commented
Sep 24, 2021
Member
@stephentoub@geoffkizer can you please do final code review on this PR? Thanks! |
stephentoub
commented
Sep 24, 2021
Member
I've left comments on the original PR. |
Member
Approved by tactics on email. |
Anipik
commented
Sep 24, 2021
Contributor
@hoyosjs can you port the rest of the commits from the original PR ? |
hoyosjs
commented
Sep 24, 2021
Member
I am waiting for the original to get fully reviewed - I will port the commit, but this is not ready to be merged until then. |
stephentoub
approved these changes
Sep 24, 2021
Anipik
commented
Sep 24, 2021
Contributor
@hoyosjs is this now ready to merge ? |
hoyosjs
commented
Sep 24, 2021
Member
It is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes ObjectCollection to use equality semantics for contain and removal of items instead of reference equality when there's a single item in the collection.
Backport of #59547 to release/6.0-rc2
Customer Impact
Customer reported break of app when checking parameters for HTTP headers that had a single value. This was a regression from 3.1.
Testing
Test added as part of this PR.
Risk
Low, there's internal usage of this and some behavioral changes (checking for
Parameters.Contains(null)inContentDispositionHeaderValue/MediaTypeHeaderValue/NameValueWithParametersHeaderValue/TransferCodingHeaderValuewhen they have no parameters returns true), but all were incorrect