Skip to content

Treat 'abstract' properties the same as 'virtual' for src-gen - #59707

Merged
steveharter merged 2 commits into
dotnet:mainfrom
steveharter:PolySrcGen
Sep 29, 2021
Merged

Treat 'abstract' properties the same as 'virtual' for src-gen#59707
steveharter merged 2 commits into
dotnet:mainfrom
steveharter:PolySrcGen

Conversation

@steveharter

@stevehartersteveharter commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Fixes#58985 for 7.0.

Expected to be ported to 6.0.

@stevehartersteveharter added this to the 7.0.0 milestone Sep 28, 2021
@stevehartersteveharter self-assigned this Sep 28, 2021
@ghost

ghost commented Sep 28, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis, @layomia, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58985 for 7.0.

Expected to be ported to 6.0.

Author:steveharter
Assignees:steveharter
Labels:

area-System.Text.Json

Milestone:7.0.0

layomia
layomia reviewed Sep 28, 2021
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/Common/ReflectionExtensions.cs Outdated
Comment thread...ries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/RealWorldContextTests.cs Outdated
layomia
layomia approved these changes Sep 29, 2021
View reviewed changes

@layomialayomia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveharter

steveharter commented Sep 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Build timeouts not related to this PR.

Test failure in collections see #58933

@steveharter
steveharter merged commit 5769db8 into dotnet:mainSep 29, 2021
@steveharter
steveharter deleted the PolySrcGen branch September 29, 2021 18:54
@steveharter

steveharter commented Sep 29, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1288153740

@github-actionsgithub-actionsBot mentioned this pull request Sep 29, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
+1 more reviewer
@layomialayomialayomia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stevehartersteveharter

Labels

area-System.Text.Json

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

JsonSourceGenerator - ArgumentException key already added.

3 participants

@steveharter@eiriktsarpalis@layomia