Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Treat 'abstract' properties the same as 'virtual' for src-gen - #59771
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersSeptember 29, 2021 18:56
ghost
commented
Sep 29, 2021
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #59707 to release/6.0 /cc @steveharter Customer ImpactTestingRisk
|
danmoseley
commented
Sep 29, 2021
Contributor
Very low risk change scoped to SG and fixing an issue reported by customer. Please send mail if you haven't already. |
ericstj
reviewed
Sep 29, 2021
| if (methodSymbol.IsAbstract) | ||
| { | ||
| attributes |= MethodAttributes.Abstract; | ||
| attributes |= MethodAttributes.Abstract | MethodAttributes.Virtual; |
Member
There was a problem hiding this comment.
LGTM, and is also more consistent with reflection:
https://sharplab.io/#v2:EYLgtghglgdgNAFxAJwK7wCYgNQB8ACATAIwCwAUPgAwAE+xAdAJIDyA3BRfQJwAUCATwAOAUwD2AM14BlBMhEQwASgYBxEQgCyGgBZiMvAEQAxADaoAzjsMqAggjlRgqBCItK2QA===
ericstj
approved these changes
Sep 29, 2021
steveharter
commented
Sep 29, 2021
Contributor
Servicing approved via mail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59707 to release/6.0
/cc @steveharter
Customer Impact
Fixes an issue where an
abstractproperty with a[JsonIgnore]attribute can cause the source generator to fail and not generate the code. If the base class is not owned by the customer, there is no work-around without this PR.Testing
A new test was added that covers the failure case as well as other permuations.
Risk
Low; the change is specific to source-gen (does not affect the normal JSON serializer) and is a one-line change specific to initializing the metadata for a method.