Skip to content

Revert bind single elements to array in configuration binder - #59716

Merged
safern merged 2 commits into
dotnet:mainfrom
safern:RevertBindSingleElementsToArray
Sep 28, 2021
Merged

Revert bind single elements to array in configuration binder#59716
safern merged 2 commits into
dotnet:mainfrom
safern:RevertBindSingleElementsToArray

Conversation

@safern

Copy link
Copy Markdown
Member

The change we introduced in: #57204 and #57872 have raised two breaks in RC1, I think we are very late in the cycle to introduce more risk and try to fix those issues.

#58852
#58330

We should revert this change and then try to do it again on 7.0.0 considering both issues that have been raised.

We should port this to 6.0 branch as well.

cc: @ericstj@danmoseley@vidommet

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

The change we introduced in: #57204 and #57872 have raised two breaks in RC1, I think we are very late in the cycle to introduce more risk and try to fix those issues.

#58852
#58330

We should revert this change and then try to do it again on 7.0.0 considering both issues that have been raised.

We should port this to 6.0 branch as well.

cc: @ericstj@danmoseley@vidommet

Author:safern
Assignees:-
Labels:

area-Extensions-Configuration

Milestone:-

@ericstj

Copy link
Copy Markdown
Member

I'm supportive of a revert here.

@safern
safern merged commit de4151e into dotnet:mainSep 28, 2021
@safern
safern deleted the RevertBindSingleElementsToArray branch September 28, 2021 23:51
@safern

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1284748506

@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@safern@ericstj@maryamariyan@eerhardt