Skip to content

Remove assert preventing empty PKCS7 exports - #59812

Merged
akoeplinger merged 1 commit into
dotnet:mainfrom
vcsjones:fix-android-empty-pkcs7
Oct 11, 2021
Merged

Remove assert preventing empty PKCS7 exports#59812
akoeplinger merged 1 commit into
dotnet:mainfrom
vcsjones:fix-android-empty-pkcs7

Conversation

@vcsjones

Copy link
Copy Markdown
Member

An empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0.

Before:

DOTNET : ((null) warning) Process terminated due to " at System.Diagnostics.DebugProvider.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition)

After:

[PASS] System.Security.Cryptography.X509Certificates.Tests.CollectionTests.ExportPkcs7_Empty

An empty PKCS7 collection is valid, so don't require the certHandles
count to be greater than 0.
@ghostghost added community-contribution Indicates that the PR has been added by a community member area-System.Security labels Sep 30, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

An empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0.

Before:

DOTNET : ((null) warning) Process terminated due to " at System.Diagnostics.DebugProvider.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition)

After:

[PASS] System.Security.Cryptography.X509Certificates.Tests.CollectionTests.ExportPkcs7_Empty
Author:vcsjones
Assignees:-
Labels:

area-System.Security, community-contribution

Milestone:-

@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

An empty PKCS7 collection is valid, so don't require the certHandles count to be greater than 0.

Before:

DOTNET : ((null) warning) Process terminated due to " at System.Diagnostics.DebugProvider.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Fail(String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage)
DOTNET : at System.Diagnostics.Debug.Assert(Boolean condition)

After:

[PASS] System.Security.Cryptography.X509Certificates.Tests.CollectionTests.ExportPkcs7_Empty
Author:vcsjones
Assignees:-
Labels:

area-System.Security, os-android, community-contribution

Milestone:-

@steveisok
steveisok self-requested a review September 30, 2021 15:26
@akoeplinger
akoeplinger merged commit 9dcde5f into dotnet:mainOct 11, 2021
@vcsjones
vcsjones deleted the fix-android-empty-pkcs7 branch October 11, 2021 14:04
@ghostghost locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@steveisok@akoeplinger@bartonjs