Uh oh!
There was an error while loading. Please reload this page.
Fix test sensitivity to PKCS7 certificate ordering - #59818
Conversation
ghost
commented
Sep 30, 2021
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
ghost
commented
Sep 30, 2021
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
ghost
commented
Sep 30, 2021
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
Quietly files an internal bug ticket. |
bartonjs
commented
Sep 30, 2021
My initial thought was "is it just reversed? can we just feed them in in a different order on Android?", but a few more seconds thought makes me guess that our other platforms end up sorting the certs by size as part of a DER SET OF ordering, and that Android is probably just taking them in the order presented. If it's the DER sort thing, then only like 20 people on the planet can reason about it, so it's not worth "normalizing" the Android behavior. |
vcsjones
commented
Sep 30, 2021
CMS/PKCS#7 as a specification talks a lot about BER, and only requires DER where canonical encoding is required, liked |
Android exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first.
Fixes#59777.
After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.