Uh oh!
There was an error while loading. Please reload this page.
Fixes based on feedback for the original #59929 - #59967
Merged
vitek-karas merged 2 commits intoOct 5, 2021
Merged
Conversation
ghost
commented
Oct 4, 2021
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsAdds apphost_version to the URL (most important fix) Cleans up some stuff in tests
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elinor Fung <elfung@microsoft.com>
vitek-karas
commented
Oct 5, 2021
MemberAuthor
CI failure is #59908 |
elinor-fung
approved these changes
Oct 5, 2021
agocke pushed a commit
to agocke/runtime
that referenced
this pull request
Oct 6, 2021
Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9)
Anipik pushed a commit
that referenced
this pull request
Oct 7, 2021
…ssing (#60045) * Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (#59929) Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (cherry picked from commit 2f76c08) * Fixes based on feedback for the original #59929 (#59967) Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9) Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds apphost_version to the URL (most important fix)
Adds version info to the error message for 6.0
Cleans up some stuff in tests