Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Show error dialog in single-file app when runtime is missing - #60045
Merged
Conversation
Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9)
ghost
commented
Oct 6, 2021
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov Issue DetailsDescription:Fix regression in error reporting where a FX-dependent single-file bundle will not produce a dialog if the needed runtime is not present on the machine. Testing: Unit tests Risk: Low.
|
jeffschwMSFT
approved these changes
Oct 6, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. We should take this for consideration in .NET 6.
vitek-karas
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customer reported issue. Currently, when a GUI FX-dependent app on a machine without the appropriate runtime, it silently fails (and there is an error about bundle version mismatch in the Event Viewer). This is a regression from 5.0, where we display a dialog box with the error and version of the runtime needed.
This change fixes the regression by adding a small piece of code to interpret a generic failure and give a better error message. The change in failure message is due to updates to the bundle version which resulted in a generic failure instead of a specific one, and this change is the minimal fix needed for the problem.
Testing
Unit tests
Risk
Low.