Skip to content

[release/6.0] Eliminate pre-built assets during source-build - #60315

Merged
Anipik merged 3 commits into
dotnet:release/6.0from
eerhardt:SourceBuildWork
Oct 13, 2021
Merged

[release/6.0] Eliminate pre-built assets during source-build#60315
Anipik merged 3 commits into
dotnet:release/6.0from
eerhardt:SourceBuildWork

Conversation

@eerhardt

@eerhardteerhardt commented Oct 12, 2021

Copy link
Copy Markdown
Member

This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.

  1. Remove RefOnly dependency versions
    This allows for source-build to replace these versions with source-built versions.
  2. Eliminate usages of pre-built packages during source-build
    See commit message for details

cc @MichaelSimons@dseefeld@ericstj

@eerhardt
Remove RefOnly dependency versions
0d6ae18
This allows for source-build to replace these versions with source-built versions.
@eerhardt
Eliminate usages of pre-built packages during source-build
5dd8cb4
* Don't build MSBuild tasks for netfx during source-build
* Don't build Microsoft.Windows.Compatibility during source-build
* Don't build test projects during source-build
* Don't restore Microsoft.DiaSymReader.Native
* Don't build source generators that target older Roslyn versions
* Don't build ILStripTask since it uses a Mono.Cecil "sources" NuGet package that isn't part of source-build
@ghost

ghost commented Oct 12, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimonsMichaelSimons mentioned this pull request Oct 12, 2021
Merged
safern
safern reviewed Oct 12, 2021
View reviewed changes
Comment threadDirectory.Build.props Outdated
@ghost

ghost commented Oct 13, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.

  1. Remove RefOnly dependency versions
    This allows for source-build to replace these versions with source-built versions.
  2. Eliminate usages of pre-built packages during source-build
    See commit message for details

cc @MichaelSimons@dseefeld@ericstj

Author:eerhardt
Assignees:-
Labels:

area-Infrastructure

Milestone:-

@eerhardt
PR feedback
68fbd37
Fix test build
safern
safern approved these changes Oct 13, 2021
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeffhandley
jeffhandley approved these changes Oct 13, 2021
View reviewed changes
Comment threadDirectory.Build.props
@Anipik

Anipik commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

SendPacketsElement_FileStreamLargeOffset_Throws has been failing quite frequently in CI. @karelz do we need a new issue for this one ?

Merging this PR as the failure is unreleated and its a tell mode change

@Anipik
Anipik merged commit f9e82e6 into dotnet:release/6.0Oct 13, 2021
@eerhardt
eerhardt deleted the SourceBuildWork branch October 13, 2021 14:25
@runfoapprunfoappBot mentioned this pull request Oct 13, 2021
Closed
@eerhardteerhardt mentioned this pull request Oct 13, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@safernsafernsafern approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@ViktorHoferViktorHoferAwaiting requested review from ViktorHofer
@eiriktsarpaliseiriktsarpalisAwaiting requested review from eiriktsarpaliseiriktsarpalis is a code owner
@layomialayomiaAwaiting requested review from layomia
@stevehartersteveharterAwaiting requested review from steveharter
+1 more reviewer
@AnipikAnipikAnipik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eerhardt@Anipik@jeffhandley@safern@danmoseley