Uh oh!
There was an error while loading. Please reload this page.
Eliminate pre-built assets during source-build - #60370
Conversation
This allows for source-build to replace these versions with source-built versions.
ghost
commented
Oct 13, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsPort of #60315 from This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.
|
* Don't build MSBuild tasks for netfx during source-build * Don't build Microsoft.Windows.Compatibility during source-build * Don't build test projects during source-build * Don't restore Microsoft.DiaSymReader.Native * Don't build source generators that target older Roslyn versions * Don't build ILStripTask since it uses a Mono.Cecil "sources" NuGet package that isn't part of source-build
4f452dc to
15fe66bCompare
ViktorHofer
left a comment
There was a problem hiding this comment.
For the .NETFramework msbuild tasks, don't we want to build them because prebuilds with them? Last time I spoke with @dseefeld he mentioned that the .NETFramework targeting packs are already available as prebuilds and are OK to be used during source build.
eerhardt
commented
Oct 14, 2021
Sort of, but not really. The reason I needed to remove the .NET Framework build for the msbuild tasks is because we are now using the "source-built" MSBuild and NuGet packages during our "2nd pass" build. However, when MSBuild and NuGet build for source-build, they only build for netstandard2.0 and net6.0 respectively, not net4x: So while you can build a net4x library in source-build, these tasks projects have other dependencies that don't. Lastly, it isn't strictly "required" to build these tasks for net4x in source-build, so it was easiest to just disable that TFM during the build. |
Port of #60315 from
release/6.0tomain.This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.
This allows for source-build to replace these versions with source-built versions.
See commit message for details