Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] <EnablePreviewFeatures> for HttpStress - #60682
Conversation
ghost
commented
Oct 20, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #59410 to release/6.0 /cc @antonfirsov Customer ImpactTestingRisk
|
antonfirsov
commented
Oct 20, 2021
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danmoseley
commented
Oct 21, 2021
@antonfirsov no special approval required to commit this. However, there's a cut off in this branch for 6.0 GA at 4pm PST Friday. After that the branch likely needs to hold all changes for a bit. |
@danmoseley In that case it would be really important to merge this and #60723 before that deadline. |
danmoseley
commented
Oct 22, 2021
@antonfirsov would it make sense to just hold this and the other one until the branch opens again for 6.0.1, next month? If it's just enabling more testing, and won't make the last build tomorrow any better? We'll no doubt be taking changes into this branch for tests and such things for the full 3 years that 6.0 will be in support. tomorrow is just the cutoff for 6.0.0. |
danmoseley
commented
Oct 22, 2021
Let's wait until branch opens for 6.0.1 If you need to do stress testing eg of the latest msquic please do so in main or locally until then |
Removing NO MERGE as it is now ready for merge into 6.0 servicing. @danmoseley does it need Approval label to be merged? Or how does it work for test-only changes? |
antonfirsov
commented
Nov 22, 2021
@karelz did you close this on purpose? Is there something that prevents us merging this? |
karelz
commented
Nov 22, 2021
Nope, that was a mistake, sorry and thanks for catching it. |
karelz
commented
Nov 30, 2021
@danmoseley ping? |
danmoseley
commented
Nov 30, 2021
Oops, missed this. No approval needed for test-only changes. As long as the branch is open. |
antonfirsov
commented
Nov 30, 2021
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
commented
Nov 30, 2021
@danmoseley what is the process for getting this and #60723 merged? Should we apply some label, or ping some people? Note that both PR-s are needed to fully fix stress runs. |
danmoseley
commented
Nov 30, 2021
Just ask @safern whether branch is open and he can merge it. Or else I can. |
safern
commented
Dec 2, 2021
The branch doesn't open until around December 17th once the branding changes are open. If this is approved we can add |
safern
commented
Dec 2, 2021
Ah this is a test only change. I'll merge it once the branch is open. |
antonfirsov
commented
Dec 2, 2021
safern
commented
Dec 2, 2021
I will look at all PRs based on target branch and milestone, so no worries, it will get merged. |
Backport of #59410 to release/6.0
/cc @antonfirsov
This is a test-only change fixing a build error in HttpStress so we can run stress tests again on
release/6.0.Example failing build on the
release/6.0branch:https://dev.azure.com/dnceng/public/_build/results?buildId=1429667&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=8ca65746-3bfa-57bf-9141-d805b5d39db5
Customer Impact
We need stress tests to assure the quality of the HTTP stack in .NET 6.0.
Testing
CI run should show if the build error is gone.
Risk
None.