Skip to content

[release/6.0] [HTTP/3] Fixed stress - #60723

Merged
safern merged 2 commits into
release/6.0from
antonfirsov/backport-60364
Dec 15, 2021
Merged

[release/6.0] [HTTP/3] Fixed stress#60723
safern merged 2 commits into
release/6.0from
antonfirsov/backport-60364

Conversation

@antonfirsov

@antonfirsovantonfirsov commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

Manual backport of #60364 to release/6.0

This is a test-only change updating msquic for HttpStress so we can run linux tests again on release/6.0.

/cc @ManickaP

Customer Impact

We need stress tests to assure the quality of the HTTP stack in .NET 6.0.

Testing

CI run should show if the build error is gone.

Risk

None.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #60364 to release/6.0

This is a test-only change updating msquic for HttpStress so we can run linux tests again on release/6.0.

Customer Impact

We need stress tests to assure the quality of the HTTP stack in .NET 6.0.

Testing

CI run should show if the build error is gone.

Risk

None.

Author:antonfirsov
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@antonfirsov

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
antonfirsov requested a review from a teamOctober 21, 2021 18:23

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're faster than me.

@antonfirsov

Copy link
Copy Markdown
ContributorAuthor

@danmoseley@karelz we need to merge this and #60682 before 6.0 GA 4pm PST Friday!

@mmitche

Copy link
Copy Markdown
Member

@danmoseley@karelz we need to merge this and #60682 before 6.0 GA 4pm PST Friday!

If this is test-only is it required for GA?

@lewinglewing added this to the 6.0.0 milestone Oct 21, 2021
@lewinglewing added the Servicing-consider Issue for next servicing release review label Oct 21, 2021
@karelz

karelz commented Oct 21, 2021

Copy link
Copy Markdown
Member

I agree that 6.0 servicing should be sufficient - whichever is easier for 6.0 shipping.

@danmoseleydanmoseley added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed Servicing-consider Issue for next servicing release review labels Oct 22, 2021
@danmoseley

Copy link
Copy Markdown
Contributor

Does'nt need servicing-consider as it's test/infra work. It does need to wait for branch to open that's all

@jeffhandleyjeffhandley modified the milestones: 6.0.0, 6.0.xNov 22, 2021
@karelzkarelz removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 22, 2021
@karelz

Copy link
Copy Markdown
Member

Removing NO MERGE, as it now can be merged.
@danmoseley does it need Approval label to be merged? Or how does it work for test-only changes?

@karelz

Copy link
Copy Markdown
Member

@danmoseley ping?

@dotnetdotnet deleted a comment from azure-pipelinesBotDec 15, 2021
@safern

Copy link
Copy Markdown
Member

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov

antonfirsov commented Dec 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@safern note that neither this PR nor #60682 is sufficient alone to fix HttpStress, we need both. (The original PR-s worked separately because they reacted to different upstream changes that came at different times.)

@safern

Copy link
Copy Markdown
Member

Thanks for the clarification. I will then merge regardless of the status of that build.

@safern
safern merged commit df64b93 into release/6.0Dec 15, 2021
@safern
safern deleted the antonfirsov/backport-60364 branch December 15, 2021 19:30
@ghostghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@antonfirsov@mmitche@karelz@danmoseley@safern@ManickaP@lewing@jeffhandley