Use generic math in System.Numerics.Vectors (#60365)

[SkiFoD]

I preserved Sqrt test logic for types that don't inherit IFloatingPoint. T.Sqrt and T.Abs usages fire the CS0119 error, however it doesn't prevent building or tests to pass.

Fixes#60365

[ghost]

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I preserved Sqrt test logic for types that don't inherit IFloatingPoint. T.Sqrt and T.Abs usages fire the CS0119 error, however it doesn't prevent building or tests to pass.

Author:	SkiFoD
Assignees:	-
Labels:	area-System.Numerics, community-contribution
Milestone:	-

[jkotas]

We do not have the support for static virtual methods fully implemented yet. See #49904 and #54063. It is likely the reason why the Mono PR CI legs fails. There are going to be more failures in outer loop test runs.

We can start using the generic math as implementation details of other features only once the static virtual methods are fully implemented.

[akoeplinger]

I tried running this on an iOS device with FullAOT and we do indeed run into some generic math AOT limitation there because it tries to JIT, e.g. System.ExecutionEngineException : Attempting to JIT compile method 'int16 System.Numerics.Tests.Util:Add<int16> (int16,int16)' while running in aot-only mode. .

So looks like we can't merge this PR until that is fixed.

[tannergooding]

Do we have any ETA on when the Mono and Crossgen2 issues will get looked at?

This is going to impact this PR as well as the follow up work I need to do here for .NET 7 and making the feature non-preview.

[akoeplinger]

@lambdageek any idea?

[tannergooding]

Merged with dotnet/main as per #49904 (comment) from @lambdageek its believed that Mono should be in a state where we can use this in the BCL.

Edit: same with #54063 (comment) from @trylek

[deeprobin]

LGTM

[tannergooding]

Merged again to pick up the CI fixes for the helix failures.

[tannergooding]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tannergooding]

@lambdageek, looks to be some tvOS failures on the Mono side that will prevent this from merging.

Could you please investigate as this is blocking our ability to work on and merge Generic Math related changes?

[lambdageek]

tvOS failures look to be the same as #65002

[lambdageek]

@tannergooding merge/rebase with main to pick up #65126 which should address the tvOS failures

[lambdageek]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tannergooding]

Merging. As with #63546, it looks like the blocking tvOS issue is gone and everything else is passing/looks good.