Uh oh!
There was an error while loading. Please reload this page.
Use static abstract interface methods in SymbolicRegexMatcher - #61631
Use static abstract interface methods in SymbolicRegexMatcher#61631stephentoub wants to merge 1 commit into
Conversation
ghost
commented
Nov 15, 2021
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue Details@tannergooding, @davidwrighton, any reason not to start relying on static abstract interface methods?
|
tannergooding
commented
Nov 15, 2021
@stephentoub, still waiting on some Mono and Crossgen2 fixes before we can: #60905 (comment)
CC. @lambdageek, @akoeplinger |
stephentoub
commented
Nov 15, 2021
Thanks, Tanner. Presumably CI will fall over with this then? 😄 |
stephentoub
commented
Nov 16, 2021
From @lambdageek's comments on the other issue, it seems like this isn't a problem as it relates to this PR (which doesn't try to take the address of such a method). What about crossgen2? CI passed; does that mean we're not crossgen'ing these assemblies as part of this build, or that any such use will cause crossgen to fail and we simply then always JIT that assembly, or something else? |
tannergooding
commented
Nov 17, 2021
@jkotas ? |
jkotas
commented
Nov 17, 2021
Right, libraries CI tests are not crossgening anything under libraries. I expect that we will see outer loop crossgen legs failing at least. We may see other failure modes as well, not sure. I think we really need to finish the crossgen support before we start using this feature in libraries. |
stephentoub
commented
Nov 17, 2021
That's fine. Do we know when that will happen? If soon, I'll leave this open. Otherwise, I'll close it. |
stephentoub
commented
Nov 17, 2021
/azp list |
stephentoub
commented
Nov 17, 2021
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
commented
Dec 10, 2021
This isn't actionable right now. Will revisit once crossgen supports it. |
@tannergooding, @davidwrighton, any reason not to start relying on static abstract interface methods?
cc: @joperezr, @olsaarik