Uh oh!
There was an error while loading. Please reload this page.
Pin Platform Manifest file to 6.0.0 Version of the file during servicing - #61260
Closed
Anipik wants to merge 4 commits into
Closed
Pin Platform Manifest file to 6.0.0 Version of the file during servicing#61260Anipik wants to merge 4 commits into
Anipik wants to merge 4 commits into
Conversation
ericstj
reviewed
Nov 5, 2021
| </Target> | ||
| <ItemGroup Condition="'$(PreReleaseVersionLabel)' == 'servicing'"> | ||
| <ReferencePlatformManifestPath Include="PlatformManifest.txt" TargetPath="data" GeneratedBuildFile="true" /> |
Member
There was a problem hiding this comment.
I'm not sure if we need GeneratedBuildFile here or not, @jkoritzinsky?
Member
There was a problem hiding this comment.
Looks like this metadata is required to avoid it showing up in the framework deps file here: https://github.com/dotnet/arcade/blob/0602cfaab1dfdbf7802dd3d2876fd17cf4ae04a7/src/Microsoft.DotNet.SharedFramework.Sdk/src/GenerateSharedFrameworkDepsFile.cs#L57
I think we can avoid the extra item though.
Anipik
commented
Nov 11, 2021
ContributorAuthor
Anipik
commented
Nov 11, 2021
ContributorAuthor
closing this in favour of #61422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#61216
Arcade change:- dotnet/arcade#8143