Skip to content

[release/6.0] Update dependencies from dotnet/arcade - #61422

Merged
Anipik merged 5 commits into
release/6.0from
darc-release/6.0-85428b80-1da0-43e1-8ffe-bdff57d0949b
Nov 15, 2021
Merged

[release/6.0] Update dependencies from dotnet/arcade#61422
Anipik merged 5 commits into
release/6.0from
darc-release/6.0-85428b80-1da0-43e1-8ffe-bdff57d0949b

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Nov 10, 2021•
edited by Anipik
Loading

Copy link
Copy Markdown
Contributor

Fixes#61216

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 36974d0f-1ebe-4d41-3a49-08d961c5a689
  • Build: 20211110.2
  • Date Produced: November 10, 2021 5:15:38 PM UTC
  • Commit: ee9b7f19853685805c612103282c8d9486c7db86
  • Branch: refs/heads/release/6.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 6.0.100
    • Updates tools.dotnet to 6.0.100

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20211…
a975f1e
…108.5
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21558.5
@ghostghost added the area-codeflow for labeling automated codeflow label Nov 10, 2021
@Anipik

Anipik commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Nov 10, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20211…
e372ca1
…110.2
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21560.2
@mmitche

mmitche commented Nov 11, 2021

Copy link
Copy Markdown
Member

@Anipik I think this is required, correct?

@Anipik

Anipik commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

yes thats correct

@mmitche

mmitche commented Nov 11, 2021

Copy link
Copy Markdown
Member

/cc @safern

@Anipik

Anipik commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

pushed #61260 into this branch to save us time.

@AnipikAnipik mentioned this pull request Nov 11, 2021
Closed
@Anipik

Anipik commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

cc @safern can you take a look at the failures here ? seems to be cause by the arcade update.

safern
safern reviewed Nov 11, 2021
View reviewed changes
Comment threadsrc/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj Outdated
@Anipik@safern
Apply suggestions from code review
881d475
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
@Anipik

Anipik commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

@maryamariyan can you take a look at the extensions failures ? arcade update is breaking this one.

@safern

safern commented Nov 12, 2021

Copy link
Copy Markdown
Member

I'm taking a look as well. I'm trying to repro locally.

@Anipik

Anipik commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

Thanks :)

@safern

safern commented Nov 13, 2021

Copy link
Copy Markdown
Member

I found the culprit. What's causing this issue is the SDK update to 6.0.100. If I revert back to the 6.0Basically what is happening is that when building test projects the PlatformManifest under the targeting pack that we produce under artifacts\bin\microsoft.netcore.app.ref\data\PlatformManifest.txt is not being found/returned by the ResolveTargetingPackAssets Task. What caused this is: dotnet/sdk@70f204b.

You can see that we also hit this when upgrading the main branch to RC2: #60256 (comment)

We are hitting this because of how we build runtime and how we generate the PlatformManifest after building some projects and hence the ref pack is cached and we don't get the PlatformManifest because the cached instance didn't have any PlatformManifest.txt.

We usually don't bump the SDK outside of infra rollouts, however since the branch is closed I think is fine and then whenever we send out the email to let people know about the 6.0.100 SDK update in main, we can mention it happened on 6.0 as well.

I'll push the workaround shortly.

FYI: @jkoritzinsky as you are driving the main SDK update.

@Anipik

Anipik commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

@safern any update on tihs one ?

@safern

safern commented Nov 15, 2021

Copy link
Copy Markdown
Member

@Anipik this is ready to be merged. The failure is unrelated.

@Anipik
Anipik merged commit 0c78d80 into release/6.0Nov 15, 2021
@safern
safern deleted the darc-release/6.0-85428b80-1da0-43e1-8ffe-bdff57d0949b branch November 15, 2021 18:16
@AnipikAnipik mentioned this pull request Nov 15, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safernsafernsafern left review comments

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anipik@mmitche@safern