Skip to content

Add nested static attribute support. - #61508

Closed
ilonatommy wants to merge 79 commits into
dotnet:mainfrom
ilonatommy:add-nested-static-attribute-support
Closed

Add nested static attribute support.#61508
ilonatommy wants to merge 79 commits into
dotnet:mainfrom
ilonatommy:add-nested-static-attribute-support

Conversation

@ilonatommy

Copy link
Copy Markdown
Member

This PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.

ilonatommyand others added 22 commits November 5, 2021 11:57
…chance it will be located out of the current assembly.
@ilonatommyilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 12, 2021
@ilonatommyilonatommy self-assigned this Nov 12, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes the nested problem but breaks 83 tests in DebuggerSuite. Before merging, fix these failing tests in a separate PR.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

ilonatommyand others added 22 commits November 18, 2021 09:35
…er.cs
Co-authored-by: Larry Ewing <lewing@microsoft.com>
…n-tests
Nested static classes fix broken tests
…tion
Fix for 4 failing tests of Count evaluation.
@ilonatommy

Copy link
Copy Markdown
MemberAuthor

To be merged after #61660

@ilonatommy
ilonatommy marked this pull request as ready for review November 19, 2021 12:57
@ilonatommy
ilonatommy removed the request for review from marek-safarNovember 19, 2021 12:57
@ilonatommy

Copy link
Copy Markdown
MemberAuthor

Closing, as it will get merged into fix-static-attribute-support instead of main.

@ilonatommy
ilonatommy deleted the add-nested-static-attribute-support branch November 24, 2021 09:04
@ghostghost locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ilonatommy@thaystg