Uh oh!
There was an error while loading. Please reload this page.
[wasm] [debugger] Eval fixes for static class eval - #61660
Conversation
…natommy/runtime into add-static-attribute-support
…ts that fail in Consol App.
…chance it will be located out of the current assembly.
…-classes-fix-broken-tests
…n-tests Nested static classes fix broken tests
…tion Fix for 4 failing tests of Count evaluation.
radical
left a comment
There was a problem hiding this comment.
This is looking great. It does cause some test failures though, which need to be fixed.
And there are some additional cases that we should look at, but not needed in this PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…er.cs Co-authored-by: Ankit Jain <radical@gmail.com>
…er.cs Co-authored-by: Ankit Jain <radical@gmail.com>
…PR." This reverts commit 6a1b7ad.
…port Add nested static attribute support
ilonatommy
commented
Nov 24, 2021
@radical, as discussed I merged nested static evaluation PR with this one. Only 2 more tests fail on this PR in comparison to main and they are connected with lack of method evaluation without namespace (EvaluateStaticClassFromStaticMethod cannot be found in the same namespace it is declared). It will have to be solved in a separate PR. |
radical
left a comment
There was a problem hiding this comment.
Thank you for your patience, LGTM! 👍
ilonatommy
commented
Nov 24, 2021
Fixes #61462. |
Covering skipped evaluation cases from #61252. To be merged after #61252.
It fixes static classes evaluation and nested static classes evaluation. It changed nested classes access concatenation character: from "/" to ".".
Requires a follow-up Issue to fix the test: EvaluateStaticClassFromStaticMethod with parameters without the full namespace.