Skip to content

[wasm] [debugger] Eval fixes for static class eval - #61591

Closed
ilonatommy wants to merge 20 commits into
dotnet:mainfrom
radical:eval-fixes
Closed

[wasm] [debugger] Eval fixes for static class eval#61591
ilonatommy wants to merge 20 commits into
dotnet:mainfrom
radical:eval-fixes

Conversation

@ilonatommy

@ilonatommyilonatommy commented Nov 15, 2021

Copy link
Copy Markdown
Member

Covering skipped evaluation cases from #61252.

ilonatommyand others added 20 commits November 5, 2021 11:57
@ilonatommy
Using current namespace as the default place to serach for the resolv…
fab24e5
…ed class.
@ilonatommy
Add tests for static class, static fields and pausing in async method.
66b56a7
@ilonatommy
Added tests for class evaluation.
782a107
@thaystg
Fixing support to the current namespace and adding tests for it
4119de3
@ilonatommy
Merge branch 'add-static-attribute-support' ofhttps://github.com/ilo…
e275144
…natommy/runtime into add-static-attribute-support
@ilonatommy
Assuing that we search within the current assembly first. Removed tes…
ee19014
…ts that fail in Consol App.
@ilonatommy
Remove a test-duplicate that was not testing static class or static f…
89bdc49
…ields.
@ilonatommy
Fixing indentation.
5ce0f57
@ilonatommy
Refixing indentation.
62d18b6
@ilonatommy
Refix indentations again.
ce177fd
@ilonatommy
Applied the advice about adding new blank lines.
cb32402
@ilonatommy
Changed the current assembly check.
ed2577e
@ilonatommy
Extracting the check from the loop. One time check is enough.
01f46d5
@ilonatommy
Simplifying multiple test cases into one call.
d14367d
@ilonatommy
Using local function as per review suggestion.
8a82380
@ilonatommy
Added test that was skipped by mistake.
7f24d47
@ilonatommy
Added looking for the namespace in all assemblies because there is a …
367c431
…chance it will be located out of the current assembly.
@ilonatommy
Extracting value based on the current frame, not the top of stack loc…
55479c8
…ation.
@ilonatommy
Test for classes evaluated from different frames.
5f5cdf6
@radical
[wasm] MemberReferenceResolver: rework a bit to fix some cases
d020d36
@ilonatommyilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 15, 2021
@ilonatommyilonatommy self-assigned this Nov 15, 2021
@ghost

ghost commented Nov 15, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Covering skipped evaluation cases from #61252.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@ilonatommy

ilonatommy commented Nov 16, 2021

Copy link
Copy Markdown
MemberAuthor

Closing as it failed some checks. I will open another one on my own fork with the same changes and try to fix it.

@ghostghost locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing will be requested when the pull request is marked ready for reviewlewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara will be requested when the pull request is marked ready for reviewpavelsavara is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilonatommy@thaystg@radical