[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation by ilonatommy · Pull Request #61252 · dotnet/runtime

ilonatommy · 2021-11-05T10:58:56Z

No description provided.

…ed class.

ghost · 2021-11-05T10:59:01Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

…natommy/runtime into add-static-attribute-support

…ts that fail in Consol App.

…ields.

thaystg · 2021-11-09T14:28:33Z

@lewing do you want to backport this to net6?

radical

This is looking good. I just have some questions, and suggestions.

…chance it will be located out of the current assembly.

…ation.

radical · 2021-11-13T09:51:33Z

Reading the code I noticed some cases that were not being handled, so I made some changes, which can go in a separate PR, and is based on this one. d020d36

radical

LGTM! Good job 👍

Using current namespace as the default place to serach for the resolv…
fab24e5
…ed class.

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 5, 2021

ilonatommy self-assigned this Nov 5, 2021

Add tests for static class, static fields and pausing in async method.
66b56a7

ilonatommy changed the title ~~[wasm][debugger] Fix evaluation of a static class attribute~~[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluationNov 8, 2021

ilonatommy marked this pull request as ready for review November 8, 2021 11:25

ilonatommy requested a review from marek-safar as a code owner November 8, 2021 11:25

ilonatommy requested review from radical and thaystg and removed request for marek-safar November 8, 2021 11:25

thaystg reviewed Nov 8, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

ilonatommy commented Nov 8, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs

ilonatommyand others added 4 commits November 8, 2021 17:08

Added tests for class evaluation.
782a107

Fixing support to the current namespace and adding tests for it
4119de3

Merge branch 'add-static-attribute-support' ofhttps://github.com/ilo…
e275144
…natommy/runtime into add-static-attribute-support

Assuing that we search within the current assembly first. Removed tes…
ee19014
…ts that fail in Consol App.

thaystg reviewed Nov 9, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs Outdated

ilonatommy added 4 commits November 9, 2021 15:00

Remove a test-duplicate that was not testing static class or static f…
89bdc49
…ields.

Fixing indentation.
5ce0f57

Refixing indentation.
62d18b6

Refix indentations again.
ce177fd

thaystg approved these changes Nov 9, 2021
View reviewed changes

radical requested changes Nov 9, 2021
View reviewed changes

ilonatommy added 4 commits November 10, 2021 14:33

Applied the advice about adding new blank lines.
cb32402

Changed the current assembly check.
ed2577e

Extracting the check from the loop. One time check is enough.
01f46d5

Simplifying multiple test cases into one call.
d14367d

ilonatommy added 3 commits November 11, 2021 10:15

Added looking for the namespace in all assemblies because there is a …
367c431
…chance it will be located out of the current assembly.

Extracting value based on the current frame, not the top of stack loc…
55479c8
…ation.

Test for classes evaluated from different frames.
5f5cdf6

radical requested changes Nov 13, 2021
View reviewed changes

ilonatommy added 4 commits November 15, 2021 09:06

Fixing indentation and spaces.
7151177

Applied review comments for values evaluation.
5fc759e

Compressed two tests into one with MemberData.
3661c0e

Added test case of type without namespace (failing).
66ed5c2

ilonatommy requested a review from radical November 15, 2021 09:14

ilonatommy mentioned this pull request Nov 15, 2021
[wasm] [debugger] Eval fixes for static class eval #61591
Closed

radical reviewed Nov 15, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Nov 15, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Nov 15, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

Addressed Ankit advices from the review.
136f69a

ilonatommy requested a review from radical November 16, 2021 08:28

ilonatommy mentioned this pull request Nov 16, 2021
[wasm] [debugger] Eval fixes for static class eval #61660
Merged

radical reviewed Nov 16, 2021
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

radical approved these changes Nov 16, 2021
View reviewed changes

ilonatommy merged commit 10e107d into dotnet:mainNov 17, 2021

ilonatommy deleted the add-static-attribute-support branch November 18, 2021 09:31

AndyAyersMS mentioned this pull request Nov 22, 2021
arm64 jitstress failing with encoding_found assert #61944
Closed

ghost locked as resolved and limited conversation to collaborators Dec 18, 2021

Uh oh!

Conversation

ilonatommy commented Nov 5, 2021

Uh oh!

ghost commented Nov 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thaystg commented Nov 9, 2021

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radical commented Nov 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants