Skip to content

[wasm][debugger] View object attributes - DebugType=full - #62278

Merged
thaystg merged 8 commits into
dotnet:mainfrom
thaystg:thays_fix_full_pdb
Dec 8, 2021
Merged

[wasm][debugger] View object attributes - DebugType=full#62278
thaystg merged 8 commits into
dotnet:mainfrom
thaystg:thays_fix_full_pdb

Conversation

@thaystg

@thaystgthaystg commented Dec 2, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.

in VS:
image

in Chrome:
image

@ghostghost added the area-Debugger-mono label Dec 2, 2021
@ghost

ghost commented Dec 2, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

ilonatommy
ilonatommy reviewed Dec 2, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-test.cs Outdated
lewing
lewing reviewed Dec 2, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
}
catch (BadImageFormatException)
{
Console.WriteLine($"Warning: Unable to read debug information of: {Name} (use DebugType=Portable/Embedded)");

@lewinglewingDec 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could log this using https://chromedevtools.github.io/devtools-protocol/tot/Log/ have it surface to the frontend

@radicalradicalDec 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you add a LogEntry with that though?

@lewinglewingDec 2, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You emit https://chromedevtools.github.io/devtools-protocol/tot/Log/#event-entryAdded from the proxy.

@thaystgthaystgDec 6, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understood this is not supported by JSDebugger so I implemented using Runtime.consoleAPICalled.

Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-test.csproj
radical
radical reviewed Dec 2, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
radical
radical reviewed Dec 2, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
radical
radical reviewed Dec 2, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
radical
radical previously requested changes Dec 4, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 4, 2021
@thaystg@radical
Apply suggestions from code review
f788f9f
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 6, 2021
@thaystg
thaystg requested a review from radicalDecember 6, 2021 20:55
@radicalradical added the arch-wasm WebAssembly architecture label Dec 7, 2021
@ghost

ghost commented Dec 7, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.

in VS:
image

in Chrome:
image

Author:thaystg
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@thaystg
thaystg merged commit 261a2dd into dotnet:mainDec 8, 2021
@thaystgthaystg mentioned this pull request Dec 8, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing left review comments
@ilonatommyilonatommyilonatommy left review comments
@radicalradicalradical approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@radical@lewing@ilonatommy