Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [wasm][debugger] View object attributes - DebugType=full - #62543
Merged
Conversation
ghost
commented
Dec 8, 2021
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #62278 to release/6.0 /cc @thaystg Customer ImpactShow object attributes even if this object is an instantiation of a class that is in a library that uses DebugType=full. On .net 5 this works, so it's a regression. TestingUnit tests and manual tests on Blazor. RiskLow Risk, only adding a try catch when trying to read the PDB.
|
thaystg
commented
Dec 8, 2021
MemberAuthor
@lewing I did a partial backport of the PR to avoid unnecessary improvements that could cause any side effect. |
thaystg
commented
Dec 15, 2021
MemberAuthor
Approved by email. |
safern
commented
Dec 15, 2021
Member
We can merge whenever a reviewer approves the PR. |
lewing
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62278 to release/6.0
/cc @thaystg
Customer Impact
Show object attributes even if this object is an instantiation of a class that is in a library that uses DebugType=full. On .net 5 this works, so it's a regression.
Testing
Unit tests and manual tests on Blazor.
Risk
Low Risk, only adding a try catch when trying to read the PDB.