Skip to content

Dedup addprefix & delete unused defines from cmake - #62528

Merged
marek-safar merged 3 commits into
dotnet:mainfrom
am11:feature/native-configs
Dec 11, 2021
Merged

Dedup addprefix & delete unused defines from cmake#62528
marek-safar merged 3 commits into
dotnet:mainfrom
am11:feature/native-configs

Conversation

@am11

@am11am11 commented Dec 8, 2021

Copy link
Copy Markdown
Member

Commits:

  1. Dedup addprefix cmake function and delete unused defailes like PACKAGE_*, which are autoconf artifacts, unused in current cmake based setup.
  2. Change #if FALSE to #if 0 in C files.
  3. Cleanup trailing whitepaces in files from 1 and 2.

@am11
Dedup addprefix & delete unused defines from cmake
bec6a83
@am11
Change if FALSE to if 0 in C files
9944ba1
@am11
Cleanup trailing whitespace in changeset files
ab9b081
```sh
# git remote add dotnet https://github.com/dotnet/runtime && git pull --rebase dotnet main
if uname 2>/devnull | grep -q Darwin; then
space=" "
fi
git show --name-only --pretty="" HEAD...dotnet/main |\
xargs -I{} sh -c "test -f {} && sed -i$space'' 's/[[:space:]]*$//' {}"
```
@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Dec 8, 2021
@ghost

ghost commented Dec 8, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Dec 8, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Commits:

  1. Dedup addprefix cmake function and delete unused defailes like PACKAGE_*, which are autoconf artifacts, unused in current cmake based setup.
  2. Change #if FALSE to #if 0 in C files.
  3. Cleanup trailing whitepaces in files from 1 and 2.
Author:am11
Assignees:-
Labels:

area-Infrastructure, community-contribution

Milestone:-

@vargaz

vargaz commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

The mono changes look ok

@am11

am11 commented Dec 11, 2021

Copy link
Copy Markdown
MemberAuthor

@lambdageek, is it good to merge? Is so please do, I don't have write access.

@marek-safar
marek-safar merged commit 20f994c into dotnet:mainDec 11, 2021
@am11
am11 deleted the feature/native-configs branch December 12, 2021 08:43
@am11

am11 commented Dec 12, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks, I wanted to use addprefix() in #62673. :)

@ghostghost locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@imhameedimhameedAwaiting requested review from imhameed
@marek-safarmarek-safarAwaiting requested review from marek-safar
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@am11@vargaz@lambdageek@marek-safar