Uh oh!
There was an error while loading. Please reload this page.
Move a few vendor libraries to src/native/external - #62673
Merged
Conversation
MemberAuthor
cc @jkotas
The format is: src/native/external/{libname}/
src/native/external/{libname}-version.txt
src/native/external/{libname}.cmake # exception being rapidjson which is header-only lib with no build configs@janvorli, I was thinking about moving libunwind here as well and refactoring our configurations in a |
am11force-pushed
the
feature/consolidations
branch
from
December 11, 2021 17:06
3b269fc to
31c4d33Compaream11
marked this pull request as ready for review
December 11, 2021 19:09
am11
requested review from
SamMonoRT, imhameed, lambdageek, marek-safar, thaystg and vargaz
as code ownersDecember 11, 2021 19:09
MemberAuthor
Red diffs are because one copy (out of three) of zlib is deleted from the repo. |
jkotas
reviewed
Dec 11, 2021
Uh oh!
There was an error while loading. Please reload this page.
ghost
commented
Dec 11, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsMoved:
|
Except for the ones in vendor directory: ```sh # git remote add dotnet https://github.com/dotnet/runtime && git pull --rebase dotnet main if uname 2>/dev/null | grep -q Darwin; then space=" " fi git show --name-only --pretty="" HEAD...dotnet/main \ ':!*external/brotli/*' ':!*external/rapidjson/*' ':!*external/zlib/*' ':!*external/zlib-intel/*' | xargs -I{} sh -c "test -f {} && sed -i$space'' 's/[[:space:]]*$//' {}" ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved: