Use System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting

[marek-safar]

feature switch to keep native hosting ComponentActivator dependencies to bring back no trimming warnings for System.Private.Corelib.

System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting is by default disabled (false) when apps are trimmed. Users will need to pass _EnableConsumingManagedCodeFromNativeHosting to re-enable native hosting with ComponentActivator I think that's fine because ComponentActivator is marked as never trimming safe, effectively making trimming + native hosting risky configuration.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	marek-safar
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	-

[jkotas]

This was added in #59962

[lambdageek]

@marek-safar Mono uses these too, to implement the coreclr_create_delegate hosting API. We need it to at least run the DllImportGenerator tests (right now only on desktop mono - mobile mono needs a version of hostpolicy.cpp to run the generator tests).

There's a feature switch EnableConsumingManagedCodeFromNativeHosting that is related to these classes - perhaps we can use it to link this stuff out on mobile and wasm when it isn't needed?

[marek-safar]

Updated PR to address the issue differently

[jkotas]

_EnableConsumingManagedCodeFromNativeHosting

Naming nits: We have existing EnableCppCLIHostActivation property: https://docs.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options#framework-features-disabled-when-trimming

Would it make sense to call this one EnableNativeHostActivation to follow the naming pattern?

cc @vitek-karas@AaronRobinsonMSFT

[AaronRobinsonMSFT]

Would it make sense to call this one EnableNativeHostActivation to follow the naming pattern?

I agree with this name.

[marek-safar]

I'd prefer to do the msbuild property rename in the follow-up PR as the definition primary lives in sdk and would make sense to change it there first.

[jkotas]

I have not realized that this name is in the SDK already. Fixing it up in follow up PR sounds good.