Skip to content

Fix Queryable-to-Enumerable overload mapping logic - #65569

Merged
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:fix-queryable-overloads
Feb 24, 2022
Merged

Fix Queryable-to-Enumerable overload mapping logic#65569
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:fix-queryable-overloads

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Fix#65419.

Should be considered for .NET 6 servicing.

@ghostghost added the area-System.Linq label Feb 18, 2022
@ghost

ghost commented Feb 18, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #65419

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Linq

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 7.0.0 milestone Feb 18, 2022
eerhardt
eerhardt reviewed Feb 18, 2022
View reviewed changes
Comment threadsrc/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs
Comment threadsrc/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs
eerhardt
eerhardt approved these changes Feb 22, 2022
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thinking of any better approaches here, so if this approach works and is the best approach you can think of, LGTM.

Comment threadsrc/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs
Comment threadsrc/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs Outdated
@runfoapprunfoappBot mentioned this pull request Feb 23, 2022
Closed
@eiriktsarpalis
eiriktsarpalis merged commit 96cd39d into dotnet:mainFeb 24, 2022
@eiriktsarpalis

eiriktsarpalis commented Feb 24, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1894781449

@github-actionsgithub-actionsBot mentioned this pull request Feb 24, 2022
Merged
@eiriktsarpalis
eiriktsarpalis deleted the fix-queryable-overloads branch February 24, 2022 20:39
@ghostghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes
@krwqkrwqAwaiting requested review from krwq
@layomialayomiaAwaiting requested review from layomia

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Linq

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

The value returned by AsQueryable().FirstOrDefault is different between Net5.0 and Net6.0

2 participants

@eiriktsarpalis@eerhardt