Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix Queryable-to-Enumerable overload mapping logic - #65857
Merged
Conversation
ghost
commented
Feb 24, 2022
Tagging subscribers to this area: @dotnet/area-system-linq Issue DetailsBackport of #65569 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
eerhardt
approved these changes
Feb 24, 2022
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks like a clean backport. LGTM
ericstj
approved these changes
Mar 10, 2022
ericstj
left a comment
Member
There was a problem hiding this comment.
LGTM -- no need for package authoring as this only ships in framework.
ericstj
commented
Mar 10, 2022
Member
Failure is fixed by #66366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #65569 to release/6.0
/cc @eiriktsarpalis
Customer Impact
Addresses a customer reported regression from .NET 5 (#65419). The inclusion of new
FirstOrDefault/SingleOrDefault/LastOrDefaultoverloads in .NET 6 has surfaced a bug in our Queryable-to-Enumerable method mapping logic in System.Linq.Queryable.Testing
Added unit tests verifying that the regression no longer occurs.
Risk
Low to moderate. Updates the product code to account for the corner case introduced by the new overloads.