') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono][jit] Transition the x86 backend to use SSE for fp arithmetic. by vargaz · Pull Request #65723 · dotnet/runtime · GitHub
Skip to content

[mono][jit] Transition the x86 backend to use SSE for fp arithmetic. - #65723

Merged
vargaz merged 10 commits into
dotnet:mainfrom
vargaz:x86-sse
Aug 8, 2022
Merged

[mono][jit] Transition the x86 backend to use SSE for fp arithmetic.#65723
vargaz merged 10 commits into
dotnet:mainfrom
vargaz:x86-sse

Conversation

@vargaz

@vargazvargaz commented Feb 22, 2022•
edited by akoeplinger
Loading

Copy link
Copy Markdown
Contributor
  • Add SSE2 and FCMOV to the cpu requirements for mono on x86.
  • Also force the usage of r4fp on x86, the same as on arm.
  • Most of the code is copied from amd64-codegen.h and
    mini-amd64.c.

Fixes#65557

@ghostghost assigned vargazFeb 22, 2022
@vargaz

vargaz commented Feb 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Todo:

  • Compile the runtime itself with -msse2 -mfpmath=sse on x86
  • Remove unused fp stack code
  • Remove the old non-r4fp code

@vargaz

vargaz commented Feb 22, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 22, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Feb 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Fixes #65557

@vargaz
vargazforce-pushed the x86-sse branch 4 times, most recently from e31abe9 to 51abe71CompareFebruary 22, 2022 19:08
@vargaz

vargaz commented Feb 22, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 22, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

akoeplinger commented Feb 22, 2022

Copy link
Copy Markdown
Member

Please also reenable the tests that were disabled with ActiveIssue in src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.cs

@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

CI failures are unrelated, this PR only affects 32 bit x86.

@vargaz
vargaz requested a review from BrzVlad as a code ownerFebruary 23, 2022 18:20
@vargaz

vargaz commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Aug 7, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 7, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Aug 8, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Aug 8, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented Aug 8, 2022

Copy link
Copy Markdown
ContributorAuthor

The failures are fixed now. Should this be in 7.0 ?
@lambdageek

@runfoapprunfoappBot mentioned this pull request Aug 8, 2022
Open
@lambdageek

lambdageek commented Aug 8, 2022

Copy link
Copy Markdown
Member

The failures are fixed now. Should this be in 7.0 ? @lambdageek

Yea, I think we should take this in 7

@vargaz
vargaz merged commit e71a958 into dotnet:mainAug 8, 2022
@vargaz
vargaz deleted the x86-sse branch August 8, 2022 15:21
@vargazvargaz mentioned this pull request Aug 9, 2022
Closed
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Aug 12, 2022
@akoeplinger
Fix build error in mini-ppc.h
a8ff860
Looks like this got inadvertently broken by dotnet#65723
@akoeplingerakoeplinger mentioned this pull request Aug 12, 2022
Merged
akoeplinger added a commit that referenced this pull request Aug 12, 2022
@akoeplinger
Fix build error in mini-ppc.h (#73845)
77d9533
Looks like this got inadvertently broken by #65723
This was referenced Aug 12, 2022
Closed
Closed
This was referenced Aug 17, 2022
Closed
Merged
akoeplinger pushed a commit that referenced this pull request Aug 18, 2022
@mkhamoyan
Enable Android x86 double related issues (#74080)
d37ef82
Issue was fixed by #65723, enabling all related tests.
Fixes#72862Fixes#37093Fixes#71252Fixes#68906
@ghostghost locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrzVladBrzVladBrzVlad approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@lateralusXlateralusXAwaiting requested review from lateralusX

Assignees

@vargazvargaz

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android][x86] System.Runtime.InteropServices.Tests.NFloatTests failed

4 participants

@vargaz@akoeplinger@lambdageek@BrzVlad