Skip to content

[release/7.0-preview4] Backport new Tar APIs - #68337

Merged
carlossanlop merged 6 commits into
dotnet:release/7.0-preview4from
carlossanlop:BackportTar
Apr 22, 2022
Merged

[release/7.0-preview4] Backport new Tar APIs#68337
carlossanlop merged 6 commits into
dotnet:release/7.0-preview4from
carlossanlop:BackportTar

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Apr 21, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of #67883 to release/7.0-preview4

@danmoseley@jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

@carlossanlopcarlossanlop added the Servicing-consider Issue for next servicing release review label Apr 21, 2022
@carlossanlopcarlossanlop added this to the 7.0.0 milestone Apr 21, 2022
@carlossanlopcarlossanlop self-assigned this Apr 21, 2022
@ghost

ghost commented Apr 21, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Apr 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67883 to release/7.0-preview4

@danmoseley@jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

Author:carlossanlop
Assignees:carlossanlop
Labels:

Servicing-consider, area-Meta, new-api-needs-documentation

Milestone:7.0.0

adamsitnik
adamsitnik approved these changes Apr 21, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost

ghost commented Apr 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67883 to release/7.0-preview4

@danmoseley@jeffhandley

Customer Impact

We added new APIs to provide Tar creation and reading support to .NET and we would like to start getting a usage signal on them.

Testing

The PR includes tests for all the features, including a good variety of edge cases.

Risk

Low. These new features live in their own new assembly and are not being consumed by other features.

Author:carlossanlop
Assignees:carlossanlop
Labels:

Servicing-consider, area-System.IO, new-api-needs-documentation

Milestone:7.0.0

jeffhandley
jeffhandley approved these changes Apr 21, 2022
View reviewed changes

@jeffhandleyjeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supportive of this getting backported into Preview 4. It's net-new functionality that is valuable to include in the preview, and the risk to the product is minimal.

carlossanlop
carlossanlop commented Apr 21, 2022
View reviewed changes
Comment threadsrc/libraries/NetCoreAppLibrary.props Outdated
@carlossanlopcarlossanlop mentioned this pull request Apr 21, 2022
Merged
@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 21, 2022
ViktorHofer
ViktorHofer reviewed Apr 21, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj Outdated
ViktorHofer
ViktorHofer reviewed Apr 21, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj Outdated
@runfoapprunfoappBot mentioned this pull request Apr 21, 2022
Closed
@carlossanlop

carlossanlop commented Apr 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Included @danmoseley 's fix that blocked CI: #68361

@carlossanlop
carlossanlop merged commit 083181f into dotnet:release/7.0-preview4Apr 22, 2022
@carlossanlop
carlossanlop deleted the BackportTar branch April 22, 2022 16:17
@ghostghost locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj left review comments
@jeffhandleyjeffhandleyjeffhandley approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@danmoseleydanmoseleyAwaiting requested review from danmoseley

Assignees

@carlossanlopcarlossanlop

Labels

area-System.Formats.Tarnew-api-needs-documentationServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@jeffhandley@adamsitnik@danmoseley@ViktorHofer@ericstj@leecow