Skip to content

Add System.Formats.Tar assembly to NetCoreAppLibrary.props - #68343

Merged
carlossanlop merged 4 commits into
dotnet:mainfrom
carlossanlop:EnableTarAssemblyShipping
Apr 21, 2022
Merged

Add System.Formats.Tar assembly to NetCoreAppLibrary.props#68343
carlossanlop merged 4 commits into
dotnet:mainfrom
carlossanlop:EnableTarAssemblyShipping

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

This allows us to ship the assembly as part of the shared framework.

Will need this change merged to main so it can be included in this preview4 backport PR: #68337

@carlossanlopcarlossanlop added this to the 7.0.0 milestone Apr 21, 2022
@carlossanlopcarlossanlop self-assigned this Apr 21, 2022
@ghost

ghost commented Apr 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This allows us to ship the assembly as part of the shared framework.

Will need this change merged to main so it can be included in this preview4 backport PR: #68337

Author:carlossanlop
Assignees:carlossanlop
Labels:

area-System.IO

Milestone:7.0.0

@carlossanlopcarlossanlop mentioned this pull request Apr 21, 2022
Merged
ViktorHofer
ViktorHofer approved these changes Apr 21, 2022
View reviewed changes

@ViktorHoferViktorHofer left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are already on it, can you please remove the PackageDescription as this library doesn't ship as an OOB: https://github.com/carlossanlop/runtime/blob/812f54f6d8e306ec609f1d078d9995e327bdfad7/src/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj#L6-L14

Asking as devs looking at the lib will be confused regarding how the library ships.

@carlossanlop

carlossanlop commented Apr 21, 2022

Copy link
Copy Markdown
ContributorAuthor

@ViktorHofer done.

@carlossanlop
carlossanlop merged commit f00615c into dotnet:mainApr 21, 2022
@carlossanlop
carlossanlop deleted the EnableTarAssemblyShipping branch April 21, 2022 21:10
@ghostghost locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@danmoseleydanmoseleyAwaiting requested review from danmoseley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-System.Formats.Tar

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@jeffhandley