Updating Complex to implement INumberBase and ISignedNumber

[tannergooding]

No description provided.

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	tannergooding
Assignees:	tannergooding
Labels:	area-System.Numerics, new-api-needs-documentation
Milestone:	-

[tannergooding]

@marek-safar, @agocke, @davidwrighton

This is likely going to fail. I'm getting the following locally:

System.TypeLoadException : Virtual static method 'get_One' is not implemented on type 'System.Numerics.Complex' from assembly 'System.Runtime.Numerics, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

In obj

• .\artifacts\obj\System.Runtime.Numerics\Release\net7.0\PreTrim\System.Runtime.Numerics.dll looks correct
• .\artifacts\obj\System.Runtime.Numerics\Release\net7.0\System.Runtime.Numerics.dll looks correct

In bin

• artifacts\bin\System.Runtime.Numerics\Release\net7.0\System.Runtime.Numerics.dll looks correct
• testhost\net7.0-windows-Release-x64\shared\Microsoft.NETCore.App\7.0.0\System.Runtime.Numerics.dll looks correct

There is no copy of System.Runtime.Numerics.dll in the bin or obj folder for System.Runtime.Numerics.Tests

It's not clear if this is some trimming issue or VM metadata issue or something else. I'd likely lean towards the latter based on the assemblies I'm seeing having the relevant members defined, but this is problematic and blocking the PR.

[tannergooding]

There isn't really anything special about Complex here. The only "notable" thing is that its not in S.P.Corelib where-as the primitives, Guid, DateTime, and NFloat are.

[agocke]

I can look at the trimmed DLL and see if it's missing anything if you can share it out

[tannergooding]

VS reports the test is loading the assembly from .\bin\testhost\net7.0-windows-Release-x64\shared\Microsoft.NETCore.App\7.0.0\System.Runtime.Numerics.dll and ildasm/dotPeek/ilspy all show that private static Complex System.Numerics.INumberBase<System.Numerics.Complex>.One { get; } still exists (as does public static readonly Complex One;, but that shouldn't be impactful).

Binary is here: System.Runtime.Numerics.dll.zip

But I have no clue if there is potentially something else missing as well.

[tannergooding]

CC. @trylek as well, since this may be a VM issue

[agocke]

Might be missing a methodimpl here, + @jtschuster. I have to grab the pre-trimmed binary to be sure.

[tannergooding]

Here's the obj folder (just for S.R.Numerics): System.Runtime.Numerics.zip

Contains both the trimmed and pre-trimmed output (the latter in the PreTrim folder).

[agocke]

Yup, MethodImpl is being dropped. This is a linker bug.

[tannergooding]

Thanks much for looking!

[marek-safar]

Yes, this is "expected" as linker work has not been completed. Tracking issue is dotnet/linker#2058

[tannergooding]

This is ready for review now.

[dakersnar]

Looks good!