Uh oh!
There was an error while loading. Please reload this page.
[main] Update dependencies from dotnet/linker - #68650
Conversation
…427.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22227.1
…428.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22228.1
…429.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22229.2
marek-safar
commented
May 2, 2022
@vitek-karas could you look into a new error? |
vitek-karas
commented
May 2, 2022
This is analyzer failure on ILGenerator.cs:1140 (and others) the code pattern looks like this: privateconststringConsoleTypeFullName="System.Console, System.Console";privatevoidMethod(){Type.GetType(ConsoleTypeFullName,throwOnError:true);// IL2057}In linker this doesn't happen because the const field is effectively "inlined" into the IL by the compiler, so linker sees a constant string value and can resolve it. But analyzer apparently doesn't. I'll look a bit more into this if the analyzer could figure this out, if not easily we will just suppress it for now and probably change the analyzer to not produce a warning in this case (ignore the problem). |
vitek-karas
commented
May 2, 2022
dotnet/linker#2774 - this will teach the analyzer to recognize const fields and improve data flow tracking in such cases. |
vitek-karas
commented
May 3, 2022
The fix on the analyzer side has been merged. Waiting for DARC to pick it up once a new build is available. |
…502.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22252.2
tannergooding
commented
May 3, 2022
This should unblock #68612 |
tannergooding
commented
May 3, 2022
Is |
vitek-karas
commented
May 4, 2022
I will merge this and take the maestro issue offline with the right people. |
This pull request updates the following dependencies
From https://github.com/dotnet/linker