Refactor wasmappbuilder's System.Text.Json reference to use a versions.props property by MichaelSimons · Pull Request #70582 · dotnet/runtime

MichaelSimons · 2022-06-10T19:13:35Z

The current hardcoded version reference causes issues with source-build:

 /repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: Detected package downgrade: System.Text.Json from 7.0.0-preview.5.22272.3 to 6.0.0. Reference the package directly from the project to select a different version. [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]
/repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: WasmAppBuilder -> Microsoft.Build 17.3.0-preview-22263-02 -> System.Text.Json (>= 7.0.0-preview.5.22272.3) [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]
/repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: WasmAppBuilder -> System.Text.Json (>= 6.0.0) [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]

Refactoring the wasmappbuilder.csproj to utilize a versions.props property for the System.Text.Json version will correct this issue.

… versions.props property

radical · 2022-06-10T23:47:00Z

Why doesn't this fail for the non-source-build? Also, this needs to be tested on windows too. @lambdageek do you think this might cause any issues on windows?

ghost · 2022-06-10T23:47:10Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The current hardcoded version reference causes issues with source-build:

 /repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: Detected package downgrade: System.Text.Json from 7.0.0-preview.5.22272.3 to 6.0.0. Reference the package directly from the project to select a different version. [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]
/repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: WasmAppBuilder -> Microsoft.Build 17.3.0-preview-22263-02 -> System.Text.Json (>= 7.0.0-preview.5.22272.3) [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]
/repos/tarball/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj : error NU1605: WasmAppBuilder -> System.Text.Json (>= 6.0.0) [/repos/tarball/src/runtime/artifacts/source-build/self/src/Build.proj]

Refactoring the wasmappbuilder.csproj to utilize a versions.props property for the System.Text.Json version will correct this issue.

Author:	MichaelSimons
Assignees:	MichaelSimons
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

radical · 2022-06-10T23:49:03Z

Linux/AOT test failing with:

System.TypeLoadException: Could not load type 'System.Runtime.CompilerServices.CompilerFeatureRequiredAttribute' from assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
at System.ModuleHandle.ResolveType(QCallModule module, Int32 typeToken, IntPtr* typeInstArgs, Int32 typeInstCount, IntPtr* methodInstArgs, Int32 methodInstCount, ObjectHandleOnStack type)
at System.ModuleHandle.ResolveTypeHandle(Int32 typeToken, RuntimeTypeHandle[] typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext)
at System.Reflection.RuntimeModule.ResolveType(Int32 metadataToken, Type[] genericTypeArguments, Type[] genericMethodArguments)
at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(MetadataToken caCtorToken, MetadataImport& scope, RuntimeModule decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType, Boolean mustBeInheritable, ListBuilder`1& derivedAttributes, RuntimeType& attributeType, IRuntimeMethodInfo& ctorWithParameters, Boolean& isVarArg)
at System.Reflection.CustomAttribute.IsCustomAttributeDefined(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Int32 attributeCtorToken, Boolean mustBeInheritable)
at System.Reflection.CustomAttribute.IsDefined(RuntimeType type, RuntimeType caType, Boolean inherit)
at System.Diagnostics.StackTrace.ToString(TraceFormat traceFormat, StringBuilder sb)
at System.Diagnostics.StackTrace.ToString(TraceFormat traceFormat)
at System.Exception.get_StackTrace()
at System.Exception.ToString()
at Microsoft.Build.BackEnd.Logging.LoggingService.LogFatalError(BuildEventContext buildEventContext, Exception exception, BuildEventFileInfo file, String messageResourceName, Object[] messageArgs)
at Microsoft.Build.BackEnd.Logging.LoggingService.LogFatalTaskError(BuildEventContext buildEventContext, Exception exception, BuildEventFileInfo file, String taskName)
at Microsoft.Build.BackEnd.Logging.BuildLoggingContext.LogFatalTaskError(Exception exception, BuildEventFileInfo file, String taskName)
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
at Microsoft.Build.BackEnd.TaskBuilder.InitializeAndExecuteTask(TaskLoggingContext taskLoggingContext, ItemBucket bucket, IDictionary`2 taskIdentityParameters, TaskHost taskHost, TaskExecutionMode howToExecuteTask)
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteBucket(TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask, Dictionary`2 lookupHash)
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteTask(TaskExecutionMode mode, Lookup lookup)
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteTask(TargetLoggingContext loggingContext, BuildRequestEntry requestEntry, ITargetBuilderCallback targetBuilderCallback, ProjectTargetInstanceChild taskInstance, TaskExecutionMode mode, Lookup inferLookup, Lookup executeLookup, CancellationToken cancellationToken)
at Microsoft.Build.BackEnd.TargetEntry.ProcessBucket(ITaskBuilder taskBuilder, TargetLoggingContext targetLoggingContext, TaskExecutionMode mode, Lookup lookupForInference, Lookup lookupForExecution)
at Microsoft.Build.BackEnd.TargetEntry.ExecuteTarget(ITaskBuilder taskBuilder, BuildRequestEntry requestEntry, ProjectLoggingContext projectLoggingContext, CancellationToken cancellationToken)
at Microsoft.Build.BackEnd.TargetBuilder.ProcessTargetStack(ITaskBuilder taskBuilder)
at Microsoft.Build.BackEnd.TargetBuilder.BuildTargets(ProjectLoggingContext loggingContext, BuildRequestEntry entry, IRequestBuilderCallback callback, String[] targetNames, Lookup baseLookup, CancellationToken cancellationToken)
at Microsoft.Build.BackEnd.RequestBuilder.BuildProject()
at Microsoft.Build.BackEnd.RequestBuilder.BuildAndReport()

radical · 2022-06-10T23:49:12Z

/azp run runtime-wasm

azure-pipelines · 2022-06-10T23:49:24Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-06-10T23:49:54Z

Same failure on windows too: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-70582-merge-37ae2b07af5c4a54b3/normal-System.Runtime.Tests/1/console.05aaf035.log?helixlogtype=result

lambdageek · 2022-06-11T13:14:59Z

Why doesn't this fail for the non-source-build? Also, this needs to be tested on windows too. @lambdageek do you think this might cause any issues on windows?

The issue on windows in the past was when we requested a version that was newer than what comes with the visual studio version of msbuild - which caused problems with running the task from inside VS.

ghost · 2022-06-28T21:02:43Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

kasperk81 · 2022-07-07T17:37:31Z

 <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />
 <PackageReference Include="System.Reflection.MetadataLoadContext" Version="4.7.1" />
- <PackageReference Include="System.Text.Json" Version="6.0.0" PrivateAssets="all" />
+ <PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" PrivateAssets="all" />


Suggested change
<PackageReferenceInclude="System.Text.Json"Version="$(SystemTextJsonVersion)"PrivateAssets="all" />

<PackageReferenceInclude="System.Text.Json"Condition="'$(DotNetBuildFromSource)' != 'true'"Version="6.0.0"PrivateAssets="all" />
<PackageReferenceInclude="System.Text.Json"Condition="'$(DotNetBuildFromSource)' == 'true'"Version="$(SystemTextJsonVersion)"PrivateAssets="all" />
@lambdageek this?

That seems reasonable to me, thanks!

I applied the suggested pattern.

ghost · 2022-07-21T21:02:36Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

…builder-systemtextjsonversion

MichaelSimons · 2022-07-27T14:48:51Z

 <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />
- <PackageReference Include="System.Reflection.MetadataLoadContext" Version="4.7.1" />
- <PackageReference Include="System.Text.Json" Version="6.0.0" PrivateAssets="all" />
+ <PackageReference Include="System.Reflection.MetadataLoadContext" Version="$(SystemReflectionMetadataLoadContextVersion)" />


I realized we need to do the same for the MetadataLoadContext. Can this reference a shared versions.props property of should if follow the suggested source-build conditioned pattern?

MichaelSimons · 2022-08-05T21:11:32Z

@kasperk81, @lambdageek - Any objects to merging this PR?

radical · 2022-08-05T23:36:32Z

/azp run runtime-wasm

azure-pipelines · 2022-08-05T23:36:46Z

Azure Pipelines successfully started running 1 pipeline(s).

Refactor wasmappbuilder's System.Text.Json version reference to use a…
bfd3c8f
… versions.props property

MichaelSimons requested a review from radical June 10, 2022 19:13

ghost added the area-Build-mono label Jun 10, 2022

ghost assigned MichaelSimons Jun 10, 2022

radical added the arch-wasm WebAssembly architecture label Jun 10, 2022

radical added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 14, 2022

ghost added the no-recent-activity label Jun 28, 2022

kasperk81 reviewed Jul 7, 2022
View reviewed changes

ghost removed the no-recent-activity label Jul 7, 2022

ghost added the no-recent-activity label Jul 21, 2022

ghost removed the no-recent-activity label Jul 21, 2022

MichaelSimons added 2 commits July 27, 2022 14:43

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto wasmapp…
f899782
…builder-systemtextjsonversion

Update per code review and refactor MetadataLoadContext version
90b6498

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 27, 2022

MichaelSimons commented Jul 27, 2022
View reviewed changes

runfoappBot mentioned this pull request Jul 27, 2022
System.Net.* cancellation tests fail in CI #72818
Closed

MichaelSimons requested review from kasperk81 and lambdageek and removed request for kasperk81 August 3, 2022 19:39

kasperk81 approved these changes Aug 5, 2022
View reviewed changes

lambdageek approved these changes Aug 6, 2022
View reviewed changes

radical approved these changes Aug 6, 2022
View reviewed changes

radical merged commit 667c170 into dotnet:mainAug 6, 2022

carlossanlop mentioned this pull request Aug 12, 2022
Product dependencies in Versions.props must be on the latest patch version for libraries dependencies #73871
Merged

ghost locked as resolved and limited conversation to collaborators Sep 5, 2022

- <PackageReferenceInclude="System.Text.Json"Version="$(SystemTextJsonVersion)"PrivateAssets="all" />
+<!-- When we requested a version that is newer than what comes with Visual Studio version of msbuild, it causes problems with
+ running the task from inside VS. Therefore, we are using the moving version only for source-build. -->
+ <PackageReferenceInclude="System.Text.Json"Condition="'$(DotNetBuildFromSource)' != 'true'"Version="6.0.0"PrivateAssets="all" />
+ <PackageReferenceInclude="System.Text.Json"Condition="'$(DotNetBuildFromSource)' == 'true'"Version="$(SystemTextJsonVersion)"PrivateAssets="all" />

Uh oh!

Conversation

MichaelSimons commented Jun 10, 2022

Uh oh!

radical commented Jun 10, 2022

Uh oh!

ghost commented Jun 10, 2022

Uh oh!

radical commented Jun 10, 2022

Uh oh!

radical commented Jun 10, 2022

Uh oh!

azure-pipelinesBot commented Jun 10, 2022

Uh oh!

radical commented Jun 10, 2022

Uh oh!

lambdageek commented Jun 11, 2022

Uh oh!

ghost commented Jun 28, 2022

Uh oh!

kasperk81Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

lambdageekJul 21, 2022

Choose a reason for hiding this comment

Uh oh!

MichaelSimonsJul 27, 2022

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 21, 2022

Uh oh!

MichaelSimonsJul 27, 2022

Choose a reason for hiding this comment

Uh oh!

MichaelSimons commented Aug 5, 2022

Uh oh!

radical commented Aug 5, 2022

Uh oh!

azure-pipelinesBot commented Aug 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants