Uh oh!
There was an error while loading. Please reload this page.
Product dependencies in Versions.props must be on the latest patch version for libraries dependencies - #73871
Conversation
ghost
commented
Aug 12, 2022
carlossanlop
commented
Aug 12, 2022
@radical@lambdageek are you ok with bumping the System.Reflection.Metadata.LoadContext package version to the latest stable one? You own the code that could be impacted. @MichaelSimons merely introduced the package to support |
lambdageek
commented
Aug 13, 2022
@carlossanlop I think that's fine. in the past we've had problems with depending on rolling build versions of out of band packages which led to breakage when our task would run on .NET Framework inside VS msbuild. (see the comment below), but stable versions should be ok, I think runtime/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Lines 23 to 26 in 667c170 |
lewing
commented
Aug 14, 2022
Yeah the concern here is that the task continues to work with VS/msbuild |
carlossanlop
commented
Aug 15, 2022
@lewing if I bump the version of the package, how do we verify it is still working with VS/msbuild? |
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
radical
commented
Aug 15, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
commented
Aug 15, 2022
@radical any concerns about the wasm CI failures? I'm looking at the rest. |
re:wasm, can't say for sure yet. I'm having trouble even loading the console logs from the helix test runs. |
radical
commented
Aug 15, 2022
@carlossanlop Can you merge |
…rsion for libraries dependencies
carlossanlop
commented
Aug 15, 2022
@radical done. |
radical
commented
Aug 16, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
commented
Aug 16, 2022
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
commented
Aug 16, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
commented
Aug 16, 2022
This will have to be backported to rc1. |
carlossanlop
commented
Aug 16, 2022
/backport to release/7.0-rc1 |
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2870765762 |
Addresses item no. 2 of: #72111
Pending clarification:
This PR introduced the entry a few days ago but with an older version than the latest stable released version. Waiting for @radical and/or @lewing for confirmation that we can bump it to the latest stable version, per this comment.
Changed (newer stable version found):
Unchanged (already in latest stable version):
Ignored: