Skip to content

Delete more verification code - #72747

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
SingleAccretion:Delete-Dead-Verification-Code-Upstream
Sep 22, 2022
Merged

Delete more verification code#72747
jakobbotsch merged 2 commits into
dotnet:mainfrom
SingleAccretion:Delete-Dead-Verification-Code-Upstream

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Jul 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Mostly just dead code, the only semantic change is around tailcall checks used for stress, they don't check type compatibility in the strict type system sense anymore.

Contributes to #32648.

No diffs (modulo a small TP win).

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jul 24, 2022
@ghost

ghost commented Jul 24, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Mostly just dead code, the only semantic change is around tailcall checks used for stress, they don't check type compatibility in the strict type system sense anymore.

Contributes to #32648.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@SingleAccretion
SingleAccretionforce-pushed the Delete-Dead-Verification-Code-Upstream branch 2 times, most recently from bbf0466 to f2a4221CompareJuly 24, 2022 23:04
@SingleAccretion
SingleAccretion marked this pull request as ready for review July 25, 2022 10:48
@SingleAccretion
SingleAccretion marked this pull request as draft July 25, 2022 10:49
@SingleAccretion
SingleAccretionforce-pushed the Delete-Dead-Verification-Code-Upstream branch from f2a4221 to bcea870CompareJuly 25, 2022 10:54
@SingleAccretion
SingleAccretion marked this pull request as ready for review July 25, 2022 17:12
@SingleAccretion

SingleAccretion commented Jul 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@jakobbotschjakobbotsch added this to the 8.0.0 milestone Jul 29, 2022
@SingleAccretion
SingleAccretionforce-pushed the Delete-Dead-Verification-Code-Upstream branch from bcea870 to 8059243CompareAugust 22, 2022 09:33
@jakobbotsch

jakobbotsch commented Aug 24, 2022

Copy link
Copy Markdown
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

azure-pipelinesBot commented Aug 24, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@AndyAyersMS

AndyAyersMS commented Sep 14, 2022

Copy link
Copy Markdown
Member

Old jistress logs are gone because of the pipeline shift.

Let's bounce this and retrun.

@AndyAyersMS

AndyAyersMS commented Sep 14, 2022

Copy link
Copy Markdown
Member

Hopefully jitstress is clean after #75576. Libraries jitstress has at least one pre-existing issue #75644

@AndyAyersMS

AndyAyersMS commented Sep 14, 2022

Copy link
Copy Markdown
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines

azure-pipelinesBot commented Sep 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch
jakobbotsch approved these changes Sep 22, 2022
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The failures look frozen object related which should have been fixed already. Thanks for this cleanup.

@jakobbotsch
jakobbotsch merged commit a2b1811 into dotnet:mainSep 22, 2022
@SingleAccretion
SingleAccretion deleted the Delete-Dead-Verification-Code-Upstream branch September 23, 2022 17:02
@ghostghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@jakobbotsch@AndyAyersMS