Skip to content

Fix missing flags for IND(str_handle) - #75576

Merged
EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:fix-str-handle-jit
Sep 14, 2022
Merged

Fix missing flags for IND(str_handle)#75576
EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:fix-str-handle-jit

Conversation

@EgorBo

Copy link
Copy Markdown
Member

Fixes#75562
Normally, we set GTF_IND_INVARIANT for string literals when we create IND nodes representing them, but after #49576GTF_ICON_STR_HDL may be created without GT_IND first, so if it appears later - update its flags.

Also, fix eeGetCPString (used for e.g. DOTNET_JitDisasm) to handle frozen strings

cc @AndyAyersMS

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 14, 2022
@ghostghost assigned EgorBoSep 14, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75562
Normally, we set GTF_IND_INVARIANT for string literals when we create IND nodes representing them, but after #49576GTF_ICON_STR_HDL may be created without GT_IND first, so if it appears later - update its flags.

Also, fix eeGetCPString (used for e.g. DOTNET_JitDisasm) to handle frozen strings

cc @AndyAyersMS

Author:EgorBo
Assignees:EgorBo
Labels:

area-CodeGen-coreclr

Milestone:-

Comment threadsrc/coreclr/jit/ee_il_dll.cpp
Comment threadsrc/coreclr/jit/morph.cpp
@EgorBo
EgorBo merged commit 36aa98b into dotnet:mainSep 14, 2022
@ghostghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPMI runtime tests collection failure: Missing flags on tree

3 participants

@EgorBo@jakobbotsch@AndyAyersMS