Skip to content

[Android] gRPC client tests - #73060

Merged
simonrozsival merged 36 commits into
mainfrom
simonrozsival/android-grpc-client-tests
Aug 25, 2022
Merged

[Android] gRPC client tests#73060
simonrozsival merged 36 commits into
mainfrom
simonrozsival/android-grpc-client-tests

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Jul 29, 2022•
edited
Loading

Copy link
Copy Markdown
Member

To improve gRPC support on mobile platforms, we're adding CI for the Grpc.Client nuget package that runs interop tests on Android emulators. Most of the code in this PR is copied from the https://github.com/grpc/grpc-dotnet repository.

Each test builds and runs a docker container with an gRPC server and runs a functional test on an Android emulator against the server. The test will run periodically and also on demand with /run azp android-grpc-client-tests.

Contributes to #69095

simonrozsivaland others added 18 commits June 8, 2022 19:13
@simonrozsival
WIP: add gRPC tests
d2dbd2b
@simonrozsival
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto android…
ea8b368
…-grpc-client-tests
@simonrozsival
Fix AOT and trimming
1dcf0e8
@simonrozsival
WIP
2941f15
@simonrozsival
Implement IncludeNetworkSecurityConfig
66b2939
@simonrozsival
Use IncludeNetworkSecurityConfig
6ef8d85
@simonrozsival
Fix gRPC test
5740a9b
@simonrozsival
Avoid git checkout
b99fc44
@simonrozsival
Remove unnecessary code
be51a78
@simonrozsival
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto android…
0d4837c
…-grpc-client-tests
@simonrozsival
WIP: start working on CI configuration
28629ae
@simonrozsival
Remove WinHttpHandler
85eb854
@simonrozsival
Fix problem with SSL
b4b2d09
@simonrozsival
Change server host
9dac1c4
@directhex@simonrozsival
Setup CI (#1)
3a8908f
* Get Docker container building & exported via test build
* Changes
* Add missing pfx certificate
* changes
* cleanup
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Use tls
3276d50
@simonrozsival
Update yml
b7b40e7
@simonrozsival
Revert changes to the mono Android sample app
44bd21c
@simonrozsivalsimonrozsival added the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 29, 2022
@ghost

ghost commented Jul 29, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This is still WIP.

Author:simonrozsival
Assignees:-
Labels:

NO-REVIEW, area-Infrastructure-mono

Milestone:-

@dotnetdotnet deleted a comment from azure-pipelinesBotJul 29, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotJul 29, 2022
@simonrozsivalsimonrozsival mentioned this pull request Aug 1, 2022
Merged
akoeplinger
akoeplinger approved these changes Aug 22, 2022
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few license related comments but looks good otherwise

Comment threadeng/pipelines/android-grpc-client-tests.yml
Comment thread...d/Device_Emulator/gRPC/grpc-dotnet/testassets/InteropTestsWebsite/InteropTestsWebsite.csproj Outdated
Comment thread...onalTests/Android/Device_Emulator/gRPC/grpc-dotnet/testassets/Certs/InteropTests/server1.key
Comment threadsrc/tests/FunctionalTests/Android/Device_Emulator/gRPC/Android.Device_Emulator.gRPC.Test.csproj Outdated
Comment threadsrc/tests/FunctionalTests/Android/Device_Emulator/gRPC/Program.cs
Comment thread...ctionalTests/Android/Device_Emulator/gRPC/grpc-dotnet/test/Shared/HttpEventSourceListener.cs
akoeplinger
akoeplinger reviewed Aug 24, 2022
View reviewed changes
Comment threadeng/Versions.props Outdated
This was referenced Aug 24, 2022
Closed
Open
Closed
@simonrozsival
simonrozsival merged commit 7a4b0af into mainAug 25, 2022
@akoeplinger
akoeplinger deleted the simonrozsival/android-grpc-client-tests branch August 25, 2022 08:35
@akoeplingerakoeplinger mentioned this pull request Aug 25, 2022
Merged
@ChadNedzlekChadNedzlek mentioned this pull request Aug 29, 2022
Closed
radical added a commit to radical/runtime that referenced this pull request Aug 29, 2022
@radical
CI: Fix helix test results reporting
749dcc6
PR dotnet#73060 broke uploading of helix test results. This was caused by the
change:
```xml
<HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```
This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.
Fix by *appending* to the property.
Thanks to ChadNedzlek for finding the cause!
Fixesdotnet#74699 .
@radicalradical mentioned this pull request Aug 29, 2022
Merged
radical added a commit that referenced this pull request Aug 30, 2022
@radical@akoeplinger
CI: Fix helix test results reporting (#74788)
2ed931d
* CI: Fix helix test results reporting
PR #73060 broke uploading of helix test results. This was caused by the
change:
```xml
<HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```
This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.
Fix by *appending* to the property.
Thanks to ChadNedzlek for finding the cause!
Fixes#74699 .
* Disable failing tests, see #74781
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@ghostghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@directhexdirecthexAwaiting requested review from directhex

Assignees

@simonrozsivalsimonrozsival

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@steveisok@akoeplinger@directhex