Uh oh!
There was an error while loading. Please reload this page.
CI: Fix helix test results reporting - #74788
Conversation
PR dotnet#73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixesdotnet#74699 .
ghost
commented
Aug 29, 2022
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsPR #73060 broke uploading of helix test results. This was caused by the <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>This is overwriting the existing value of Fix by appending to the property. Thanks to ChadNedzlek for finding the cause! Fixes #74699 .
|
ChadNedzlek
left a comment
There was a problem hiding this comment.
Make sure the test count in the PR build comes back up to 3 millionish, and this should be good.
akoeplinger
commented
Aug 30, 2022
Looks like we had a new failing test sneak in while this was broken, disabled it (see #74781) |
radical
commented
Aug 30, 2022
Does this need to wait for these jobs that we are re-running? |
steveisok
commented
Aug 30, 2022
I think it's ok to merge because it's high impact. |
PR #73060 broke uploading of helix test results. This was caused by the
change:
This is overwriting the existing value of
$(HelixPostCommands), whichgets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.
Fix by appending to the property.
Thanks to ChadNedzlek for finding the cause!
Fixes#74699 .