Skip to content

Revert "[mono][interp] Improve tiering performance (dotnet#70649)" - #73187

Closed
lambdageek wants to merge 1 commit into
dotnet:mainfrom
lambdageek:try-fix-gh-73180
Closed

Revert "[mono][interp] Improve tiering performance (dotnet#70649)" #73187
lambdageek wants to merge 1 commit into
dotnet:mainfrom
lambdageek:try-fix-gh-73180

Conversation

@lambdageek

Copy link
Copy Markdown
Member

in AOT we may not have fields inited if we're using cached class info.

Fixes#73180

@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@ghost

ghost commented Aug 1, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

in AOT we may not have fields inited if we're using cached class info.

Fixes #73180

Author:lambdageek
Assignees:-
Labels:

area-Codegen-Interpreter-mono

Milestone:-

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

Adding initializations, and asserting that the class isn't marked with a failure didn't help. I guess the stack trace could be misleading. Need to try and repro locally.

@lambdageek
lambdageek marked this pull request as draft August 2, 2022 13:44
@lambdageek

Copy link
Copy Markdown
MemberAuthor

Trying to revert #70649 to see if that resolves it

@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

Reverting #70649 fixes the crash

@lambdageeklambdageek changed the title [interp] Init Span/ReadOnlySpan fields in get_Item/get_Length intrinsicsRevert "[mono][interp] Improve tiering performance (dotnet#70649)" Aug 2, 2022
@lambdageek
lambdageek marked this pull request as ready for review August 2, 2022 17:11
@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #73264

@ghostghost locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] System.Xml.XmlSerializer.Tests crashing with AOT

2 participants

@lambdageek@vargaz