Skip to content

[mono][interp] Make sure containing klass has field offsets initialized - #73264

Merged
radical merged 2 commits into
dotnet:mainfrom
BrzVlad:fix-tiering-regression
Aug 3, 2022
Merged

[mono][interp] Make sure containing klass has field offsets initialized#73264
radical merged 2 commits into
dotnet:mainfrom
BrzVlad:fix-tiering-regression

Conversation

@BrzVlad

@BrzVladBrzVlad commented Aug 2, 2022

Copy link
Copy Markdown
Member

Fix regression from #70649. That PR exposed a case where we coincidentally initialized a class while emitting a ctor call. After the unoptimized codegen change, that newobj emit path was no longer hit. Setup the class fields explicitly when generating code that needs them.

#73180

@ghost

ghost commented Aug 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix regression from #70649. That PR exposed a case where we coincidentally initialized a class while emitting a ctor call. After the unoptimized codegen change, that newobj emit path was no longer hit. Setup the class fields explicitly when generating code that needs them.

Author:BrzVlad
Assignees:-
Labels:

area-Codegen-Interpreter-mono

Milestone:-

@lambdageek

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BrzVlad

Copy link
Copy Markdown
MemberAuthor

Are these wasm failures expected ? @radical ?

@radical

Copy link
Copy Markdown
Member

@BrzVlad Yes, these are on main too. You can ignore them here.

@radical
radical merged commit bcdcaec into dotnet:mainAug 3, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@BrzVlad@lambdageek@radical@vargaz