Uh oh!
There was an error while loading. Please reload this page.
[wasm] just fix the crypto logging - #73468
Conversation
ghost
commented
Aug 5, 2022
Tagging subscribers to 'arch-wasm': @lewing Issue Detailstesting crypto on CI
|
pavelsavara
commented
Aug 5, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
Aug 5, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
commented
Aug 6, 2022
Having an unhandled exception handler to log the trace, specifically for tests, would be very useful in debugging these random crashes. |
radical
commented
Aug 6, 2022
Can you add a description of the problem, and the fix, in the PR description? |
In old code: In the new code: creates new object instance with the copy of references to incoming methods and we will not write to that instance after. In my other PR I moved all this code to |
radical
commented
Aug 6, 2022
And how did the bug show up in practice? |
pavelsavara
commented
Aug 6, 2022
in practice this will run infinite loop and crash the browser as Simon described here #72941 |
This only fixes wrong capture of originalConsole causing the crypto-worker to go to infinite loop when WS are not available.
This doesn't address the problem that forwarding logs to localhost WS in production is bad idea.
Contributes to #72941