Uh oh!
There was an error while loading. Please reload this page.
[wasm] asset loading for workers - #73484
Merged
Merged
Conversation
- split logging code into separate file `logging.ts` - add `dotnet.wasm` and `dotnet-crypto-worker.js` to mono-config.json - moved `readSymbolMapFile()` call to `startup.ts` - fixed bug in `setup_proxy_console()` which didn't really copy the original `log` and `error` functions of the console and caused recursion on error. - moved `init_crypto` after `mono_wasm_load_config` in `mono_wasm_pre_init_essential_async` - added new resource type `js-module-crypto` and `js-module-threads` - changed the detection of blazor startup sequence to not be disabled by presence of config, but only by config.assets having some assembly in it.
ghost
commented
Aug 5, 2022
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
pavelsavara
commented
Aug 5, 2022
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
approved these changes
Aug 6, 2022
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # src/mono/wasm/runtime/crypto-worker.ts # src/mono/wasm/runtime/workers/dotnet-crypto-worker.js
Co-authored-by: Marek Fišera <mara@neptuo.com>
pavelsavara
commented
Aug 6, 2022
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
Aug 6, 2022
MemberAuthor
Unfortunately the deadlock is still with us. Log |
radical
commented
Aug 6, 2022
Member
You can run the tests a good bunch(30?) of times on helix, which can be done in one shot as we had discussed offline. It is helpful in finding similar issues. I wonder if we should always do that for tests that depend on workers, on CI. |
# Conflicts: # src/mono/wasm/runtime/debug.ts
pavelsavara
commented
Aug 8, 2022
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 8, 2022
pavelsavara
commented
Aug 9, 2022
MemberAuthor
/azp run runtime-wasm |
|
Pull request contains merge conflicts. |
# Conflicts: # src/mono/wasm/runtime/startup.ts
pavelsavara
commented
Aug 9, 2022
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
commented
Aug 9, 2022
MemberAuthor
|
radical
commented
Aug 9, 2022
Member
The wasm/debugger test failures are unrelated, and will be fixed by #73524 . |
Member
We should queue up the crypto deadlock fix right after this. If this happens to cause any issue with crypto, then it can be fixed in that PR. |
This was referenced Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets.tslogging.tsdotnet.wasmanddotnet-crypto-worker.jsto mono-config.json viaWasmAppBuilderreadSymbolMapFile()call tostartup.tssetup_proxy_console()which didn't really copy the originalloganderrorfunctions of the console and caused recursion on error.init_cryptoaftermono_wasm_load_configinmono_wasm_pre_init_essential_asyncjs-module-cryptoandjs-module-threadsMost of this changes were moved from #73073 where is log of discussions about it
Together with dotnet/aspnetcore#43049