Uh oh!
There was an error while loading. Please reload this page.
Simplify platform macro definitions in PAL - #73530
Conversation
ghost
commented
Aug 7, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
16839f6 to
28204eaCompaream11
commented
Aug 9, 2022
@janvorli, the CI issue was fixed after the rebase. PTAL. |
janvorli
commented
Aug 18, 2022
@am11 I am sorry for the delay, I was OOF for the last 7 days. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Aug 19, 2022
@EgorBo, any idea why superpmi leg would fail the osx-arm64 checks when I updated The CI was green before |
EgorBo
commented
Aug 19, 2022
@am11 we had some issues with it and fixed them yesterday, can you rebase your PR? |
janvorli
commented
Aug 25, 2022
@am11 let me retry the superpmi tests one more time and then I'll merge it. |
It was missed in dotnet#73530, before that we defined `HOST_ARM` for armv6 in pal.h too because of `defined(__arm__)`
Add missing HOST_ARM define to armv6 in configurecompiler.cmake, it was missed in #73530, before that we defined `HOST_ARM` for armv6 in pal.h too because of `defined(__arm__)` We also only need the `clr.iltools+clr.packages` subset, not all of CoreCLR. Also fix some dependencies that weren't working for FreeBSD since we missed the local variables. We don't need installer subset conditions there but we need to trigger on rolling builds.
_M_{ARCH}definitions and replace usage withHOST_{ARCH}andTARGET_{ARCH}.${arch}from filenames in architecture specific directories.ArmfromPAL_ArmInterlockedOperationBarrierandArmInterlockedOperationBarrieras they are not ARM-specific anymore.src/coreclr/build-runtime.sh -cross -a riscv64 -component paltests(without running into missing files errors).