Skip to content

Use nproc without --all on Linux - #74696

Merged
jkotas merged 5 commits into
dotnet:mainfrom
am11:feature/native/build
Aug 30, 2022
Merged

Use nproc without --all on Linux#74696
jkotas merged 5 commits into
dotnet:mainfrom
am11:feature/native/build

Conversation

@am11

@am11am11 commented Aug 27, 2022

Copy link
Copy Markdown
Member

Also deduplicated a cmake statement I missed in #73530.

Fixes#74691.

@ghostghost added area-Infrastructure community-contribution Indicates that the PR has been added by a community member labels Aug 27, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Also deduplicated a cmake statement I missed in #73530.

Fixes #74691.

Author:am11
Assignees:-
Labels:

area-Infrastructure

Milestone:-

@am11

am11 commented Aug 27, 2022

Copy link
Copy Markdown
MemberAuthor

In dontet/diagnostics, we are still using older centos-7 because in the newer image, lldb executable in tests fail with this error.

The old centos-7 image doesn't have llvm-objcopy, so I updated objcopy introspection (for sync PR dotnet/diagnostics#3318 and also pushed a commit here) such that if llvm-objcopy is not found, it is fine to continue to binutils fallback which was added in #71742.

cc @hoyosjs, @jkotas

@jkotas
jkotas requested a review from hoyosjsAugust 27, 2022 12:11
@am11
am11force-pushed the feature/native/build branch from 75d6e9b to e7be19fCompareAugust 27, 2022 23:23
@am11
am11force-pushed the feature/native/build branch from e7be19f to ee77955CompareAugust 28, 2022 15:26
Comment threadeng/native/configurecompiler.cmake Outdated
@am11

am11 commented Aug 30, 2022

Copy link
Copy Markdown
MemberAuthor

CI is green.

@jkotas
jkotas merged commit fe9a5a4 into dotnet:mainAug 30, 2022
ayakael added a commit to ayakael/runtime that referenced this pull request Sep 13, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 29, 2022
@am11
am11 deleted the feature/native/build branch February 16, 2023 00:38
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect computation of build parallelism

3 participants

@am11@hoyosjs@jkotas