[wasm] cleanup testing and host support in templates and tests by pavelsavara · Pull Request #73785 · dotnet/runtime

pavelsavara · 2022-08-11T16:37:17Z

added new module exports dotnet, exit to dotnet.js
exit method is replacement for our internal set_exit_code
dotnet is a builder pattern with following usage

import{dotnet}from'./dotnet.js'dotnet.withDiagnosticTracing(false).withApplicationArguments("dotnet","is","great!").run()

The builder methods are

 withConfig(config: MonoConfig): DotnetHostBuilder
withConfigSrc(configSrc: string): DotnetHostBuilder
withApplicationArguments(...args: string[]): DotnetHostBuilder
withEnvironmentVariable(name: string, value: string): DotnetHostBuilder
withEnvironmentVariables(variables: { [i: string]: string; }): DotnetHostBuilder
withVirtualWorkingDirectory(vfsPath: string): DotnetHostBuilder
withDiagnosticTracing(enabled: boolean): DotnetHostBuilder
withDebugging(level: number): DotnetHostBuilder
create(): Promise<RuntimeAPI>
run(): Promise<number>

There are also internal methods useful when testing.
withRuntimeOptions, withWaitingForDebugger, withElementOnExit, withConsoleForwarding, withExitCodeLogging and withModuleConfig

changed implementation of stdout flusing on NodeJS, that it would only delay the process.exit if the exit code is 0
updated templates
updated tests
fixed license headers

TODO

update WBT to use withElementOnExit, withConsoleForwarding, withExitCodeLogging as necessary for templates test
Update WasmAppHost to always pass parameters as query string and add withApplicationArgumentFromQuery
INTERNAL.require may not work (WS unit tests)
add readme to the templates
withAsyncNodeJsFlushOnExit as non-public opt-in nodejs flush on exit (enable optionally on windows only tests?)
public API withMainAssembly for setting main assembly name
create should return this.instance once it exists
fix CI build (possibly we may need to move everything to the post.ex)
dotnet.es6.extpost.js requires a change in the SDK

Contributes to #70892
Fixes#71047

ghost · 2022-08-11T16:37:47Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

nothing yet

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`NO-MERGE`, `NO-REVIEW`, `arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	-

# Conflicts: # src/mono/wasm/test-main.js

maraf · 2022-08-12T19:24:32Z

/azp run runtime-wasm

azure-pipelines · 2022-08-12T19:24:47Z

Azure Pipelines successfully started running 1 pipeline(s).

Move all legacy API object creation to dotnet.es6.post.js where module export is created.

pavelsavara · 2022-08-13T05:47:04Z

/azp run runtime-wasm

azure-pipelines · 2022-08-13T05:47:13Z

Azure Pipelines successfully started running 1 pipeline(s).

…it is used in both scenarios (run & create).

…pers # Conflicts: # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/types.ts

Fix merge error.

maraf · 2022-08-14T10:37:55Z

/azp run runtime-wasm

azure-pipelines · 2022-08-14T10:38:08Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-08-14T15:28:46Z

/azp run runtime-wasm

azure-pipelines · 2022-08-14T15:28:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Add API for parsing applications arguments passed by the WasmAppHost.

maraf · 2022-08-14T16:15:25Z

/azp run runtime-wasm

azure-pipelines · 2022-08-14T16:15:36Z

Azure Pipelines successfully started running 1 pipeline(s).

kg · 2022-08-14T17:49:42Z

+ const { runtimeBuildInfo, setModuleImports, getAssemblyExports, runMain, getConfig } = await dotnet
+ .withConsoleForwarding()
+ .withElementOnExit()
+ .withModuleConfig({


why are we configuring some things with a literate '.withXxx' api here and then passing in a big config dictionary?

It's just for backward compatibility. We don't allow everything with those with* methods. Also this method is not "public" as it is not in the typescript public definition.

We actually don't need any of those callbacks now. They could be removed from the sample. It's just showing that they are still there and working, in case somebody needs to go low level.
This could be further improved later and it should not block the PR, I think

WebHostBuilder* seems to go with Use* or Configure* rather than With*?

lewing · 2022-08-14T19:31:54Z

The failures here seem to be the linker related problems that are also in main.

lewing · 2022-08-14T23:22:28Z

+ withDiagnosticTracing(enabled: boolean): DotnetHostBuilder;
+ withDebugging(level: number): DotnetHostBuilder;
+ withMainAssembly(mainAssemblyName: string): DotnetHostBuilder;
+ withApplicationArgumentsFromQuery(): DotnetHostBuilder;


This seems like it could have an optional string parameter that defaults to "args"

pavelsavara added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Aug 11, 2022

pavelsavara self-assigned this Aug 11, 2022

pavelsavara added 2 commits August 12, 2022 11:21

wip
866a488

wip
19a82b5

pavelsavara force-pushed the wasm_host_helpers branch from 7a97066 to 19a82b5Compare August 12, 2022 15:44

pavelsavara added 2 commits August 12, 2022 19:55

wip
3df4af7

Merge branch 'main' into wasm_host_helpers
abf28d0
# Conflicts: # src/mono/wasm/test-main.js

pavelsavara changed the title ~~[wasm] draft~~[wasm] cleanup testing and host support in templatest and testsAug 12, 2022

pavelsavara assigned radical and maraf Aug 12, 2022

pavelsavara removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 12, 2022

marafand others added 5 commits August 12, 2022 22:19

Single instance in create method.
9efa632

withMainAssembly
4920e76

withAsyncFlushOnExit
0bd3574

Fix exporting INTERNAL api.
2158b73
Move all legacy API object creation to dotnet.es6.post.js where module export is created.

fix release build
e6add0d

lambdageek self-assigned this Aug 13, 2022

maraf added 4 commits August 14, 2022 10:21

Move virtualWorkingDirectory initialization to the create method, so …
2f2f5c5
…it is used in both scenarios (run & create).

Fix applicationArguments in templates.
5f7dbc4

Update WBT.
5d0c063

Fix ENVIRONMENT_IS_*.
cf00589

maraf added 2 commits August 14, 2022 12:33

Merge remote-tracking branch 'upstream/main' into pavel/wasm_host_hel…
f4a7e82
…pers # Conflicts: # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/types.ts

Move pthreadPoolSize to MonoConfig (from internal).
4370009
Fix merge error.

Fix ConsolePublishAndRun.
0af1e05

pavelsavara marked this pull request as ready for review August 14, 2022 15:55

pavelsavara requested review from lewing and radical as code owners August 14, 2022 15:55

pavelsavara requested a review from kg August 14, 2022 15:56

maraf added 2 commits August 14, 2022 18:03

Update readme.md in templates.
95aed6c

Update WasmAppHost to always pass application arguments as query string.
ef451b1
Add API for parsing applications arguments passed by the WasmAppHost.

kg reviewed Aug 14, 2022
View reviewed changes

lewing reviewed Aug 14, 2022
View reviewed changes

lewing approved these changes Aug 14, 2022
View reviewed changes

lewing merged commit 906ec1d into dotnet:mainAug 15, 2022

maraf changed the title ~~[wasm] cleanup testing and host support in templatest and tests~~[wasm] cleanup testing and host support in templates and testsAug 15, 2022

yamachu mentioned this pull request Aug 18, 2022
[wasm] Add new javascript API types #74166
Merged

maraf mentioned this pull request Aug 23, 2022
[wasm] Clean up environment helpers duplicated from emscripten #74423
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2022

pavelsavara deleted the wasm_host_helpers branch November 29, 2022 16:22

Uh oh!

Conversation

pavelsavara commented Aug 11, 2022• edited by maraf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

ghost commented Aug 11, 2022

Uh oh!

maraf commented Aug 12, 2022

Uh oh!

azure-pipelinesBot commented Aug 12, 2022

Uh oh!

pavelsavara commented Aug 13, 2022

Uh oh!

azure-pipelinesBot commented Aug 13, 2022

Uh oh!

maraf commented Aug 14, 2022

Uh oh!

azure-pipelinesBot commented Aug 14, 2022

Uh oh!

maraf commented Aug 14, 2022

Uh oh!

azure-pipelinesBot commented Aug 14, 2022

Uh oh!

maraf commented Aug 14, 2022

Uh oh!

azure-pipelinesBot commented Aug 14, 2022

Uh oh!

kgAug 14, 2022

Choose a reason for hiding this comment

Uh oh!

marafAug 14, 2022

Choose a reason for hiding this comment

Uh oh!

pavelsavaraAug 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lewingAug 14, 2022

Choose a reason for hiding this comment

Uh oh!

lewing commented Aug 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewingAug 14, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pavelsavara commented Aug 11, 2022•
edited by maraf
Loading

pavelsavaraAug 14, 2022•
edited
Loading

lewing commented Aug 14, 2022•
edited
Loading