Skip to content

[wasm] Add new javascript API types - #74166

Merged
maraf merged 1 commit into
dotnet:mainfrom
yamachu:add-dotnet-exports-type
Aug 19, 2022
Merged

[wasm] Add new javascript API types#74166
maraf merged 1 commit into
dotnet:mainfrom
yamachu:add-dotnet-exports-type

Conversation

@yamachu

Copy link
Copy Markdown
Contributor

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

@ghostghost added area-System.Runtime.InteropServices.JavaScript community-contribution Indicates that the PR has been added by a community member labels Aug 18, 2022
@lewing
lewing requested a review from marafAugust 18, 2022 18:43

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@marafmaraf added the arch-wasm WebAssembly architecture label Aug 19, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

Author:yamachu
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, community-contribution

Milestone:-

@maraf
maraf merged commit e23f543 into dotnet:mainAug 19, 2022
@maraf

Copy link
Copy Markdown
Member

/backport to release/7.0-rc1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2887864418

@yamachu
yamachu deleted the add-dotnet-exports-type branch August 19, 2022 07:41
@ghostghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yamachu@maraf