') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test by sakno · Pull Request #74112 · dotnet/runtime · GitHub
Skip to content

Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test - #74112

Merged
dakersnar merged 2 commits into
dotnet:mainfrom
sakno:issue-70330
Aug 18, 2022
Merged

Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test#74112
dakersnar merged 2 commits into
dotnet:mainfrom
sakno:issue-70330

Conversation

@sakno

@saknosakno commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Fixes#70330

@ghostghost added area-System.Numerics community-contribution Indicates that the PR has been added by a community member labels Aug 17, 2022
@ghost

ghost commented Aug 17, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #70330

Author:sakno
Assignees:-
Labels:

area-System.Numerics

Milestone:-

@danmoseleydanmoseley changed the title Fix for issue 70330Fix for Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom testAug 18, 2022
@danmoseley

danmoseley commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Updated the title -- issue numbers in titles don't work well when looking at lists of PR's 😸

@danmoseley

danmoseley commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

.NET 7 port needed?

@sakno

sakno commented Aug 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@danmoseley , I I think yes, .NET 7 port is needed because without the fix ModPow operation gives incorrect result for some corner cases.

dakersnar
dakersnar approved these changes Aug 18, 2022
View reviewed changes

@dakersnardakersnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice catch. Thanks for the fix!

Comment threadsrc/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs
power >>= 1;
}

return result.Slice(0, resultLength);

@dakersnardakersnarAug 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this slice basically unnecessary in all cases, and causing problems in this edge case?

@saknosaknoAug 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. It doesn't exist for overload of PowCore with exponent of arbitrary length.

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this slice introduced a regression for the case of:

value: 174475926811173371108797680334274448482027679060635889276326576767485928691470272416521788770673419883076040463212449631887959313694345475337324466914914839368969988215395980439434099840700753576299320684517028939674493640310781015739837159625716992654178036326745036841619965661654305787656989089177185300627
exponent: 152266387011071825363527751452194927195391511201743678326712300944812006670853968954038119879530327815990523885596782666640476470053822766345969220504425389995206265094671158964311234812226260664473986637197447367726400093404731405598815953979171704175885394570388678952091206779039984338579147114424357147650
modulus: 15548277136038299103

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this scenario, the length of result is greater than the length of bits and so the result.CopyTo(bits) operation fails as the destination is too short.

I expect the actual issue here is that resultLength isn't being correctly tracked somewhere.

@tannergoodingtannergoodingAug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not that resultLength is incorrect, its that bits will have been mutated and may contain temporary data

Comment threadsrc/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.PowMod.cs
@dakersnar

dakersnar commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

@danmoseley Yes, I'd like to get this in for .NET 7, as this is a regression from .NET 6.

@dakersnar
dakersnar merged commit bee9904 into dotnet:mainAug 18, 2022
@dakersnar

dakersnar commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

/backport to release/7.0-rc1

@github-actions

github-actionsBot commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2885517952

@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2022
Merged
dakersnar
dakersnar reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Numerics/tests/BigInteger/modpow.cs
This was referenced Aug 25, 2022
Closed
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding left review comments
+1 more reviewer
@dakersnardakersnardakersnar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Numericscommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Random failures in System.Numerics.Tests.modpowTest.ModPowAxiom test

4 participants

@sakno@danmoseley@dakersnar@tannergooding